Fix preview height on Android for Capacitor 7 #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have reviewed the changes in this PR and compared them to capacitor-community/camera-preview#385. I believe the current PR is preferable. While the other PR adds support for insets, it introduces an issue where the preview height is correct, but the content is flush against the top edge with no padding. Manually adding top padding could conflict with the x coordinate option, potentially leading to confusing or inconsistent layout behavior. This fix is scheduled for the next upcoming build v7.0.2 @michaelwolz thank you for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #384
Alternative solution by @ryaa: #385