Skip to content

Removed chapter about exporting default messages. #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 23, 2025

Conversation

mofterdinger
Copy link
Contributor

@mofterdinger mofterdinger commented May 19, 2025

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling Mistakes

  • java/event-handlers/indicating-errors.md:135:195 Unknown word "enumaration"

Generally, for each spelling mistake there are 2 ways to fix it:

  1. Fix the spelling mistake and commit it.
  2. The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling Mistakes

  • java/event-handlers/indicating-errors.md:135:98 Unknown word "enumaration"

Generally, for each spelling mistake there are 2 ways to fix it:

  1. Fix the spelling mistake and commit it.
  2. The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.

@mofterdinger mofterdinger requested a review from beckermarc May 20, 2025 09:30
mofterdinger and others added 3 commits May 20, 2025 11:30
Co-authored-by: Marc Becker <marc.becker@sap.com>
@mofterdinger
Copy link
Contributor Author

@chgeo @renejeglinsky Hi, how can I fix these errors:

Found 2 broken link(s) to internal targets in 2 source(s): 
in: /releases/jan25
Unresolved hash link: /java/event-handlers/indicating-errors #exporting-the-default-messages

in: /releases/archive/2020/sep20
Unresolved hash link: /java/event-handlers/indicating-errors #exporting-the-default-messages

I couldn't find the folder /releases in this repo and don't know how to fix it.

Thanks,
Markus

@chgeo
Copy link
Member

chgeo commented May 20, 2025

how can I fix these errors:

Found 2 broken link(s) to internal targets in 2 source(s): 
in: /releases/jan25
Unresolved hash link: /java/event-handlers/indicating-errors #exporting-the-default-messages

in: /releases/archive/2020/sep20
Unresolved hash link: /java/event-handlers/indicating-errors #exporting-the-default-messages

I couldn't find the folder /releases in this repo and don't know how to fix it.

Thanks, Markus

/releases is in the internal repo. See there.
@mofterdinger you can use PR cap/docs#1505 for it.

@mofterdinger
Copy link
Contributor Author

mofterdinger commented May 20, 2025

@chgeo Thanks for this hint, I removed the links to the anchor #exporting-the-default-messages in both files as suggested in the same PR.

@chgeo
Copy link
Member

chgeo commented May 20, 2025

Green ✅

@mofterdinger mofterdinger enabled auto-merge May 20, 2025 17:40
@mofterdinger mofterdinger added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@mofterdinger mofterdinger added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@mofterdinger
Copy link
Contributor Author

mofterdinger commented May 23, 2025

@chgeo @renejeglinsky Hi, how can I fix this build error:

x Build failed in 39.73s
✖ building client + server bundles...
build error:
[vitepress] 1 dead link(s) found.
[vitepress] 1 dead link(s) found.
    at Object.renderStart (file:///home/runner/work/docs/docs/docs/node_modules/vitepress/dist/node/chunk-Zsoi3j4v.js:45027:15)
    at file:///home/runner/work/docs/docs/docs/node_modules/rollup/dist/es/shared/node-entry.js:22210:40
    at async Promise.all (index 0)
    at async PluginDriver.hookParallel (file:///home/runner/work/docs/docs/docs/node_modules/rollup/dist/es/shared/node-entry.js:22120:9)
    at async Bundle.generate (file:///home/runner/work/docs/docs/docs/node_modules/rollup/dist/es/shared/node-entry.js:20333:13)
    at async file:///home/runner/work/docs/docs/docs/node_modules/rollup/dist/es/shared/node-entry.js:23187:27
    at async catchUnfinishedHookActions (file:///home/runner/work/docs/docs/docs/node_modules/rollup/dist/es/shared/node-entry.js:22562:16)
Error: Process completed with exit code 1.

I don't see any information about which link is dead. This PR doesn't add new links which could be broken.

@renejeglinsky
Copy link
Contributor

The dead link is in there, a little above the error message:
image
I'll update the PR, the link is fixed

@renejeglinsky renejeglinsky enabled auto-merge May 23, 2025 10:25
@renejeglinsky renejeglinsky added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@renejeglinsky renejeglinsky merged commit 44c3f2a into main May 23, 2025
4 checks passed
@renejeglinsky renejeglinsky deleted the mofterdinger-patch-1 branch May 23, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants