Update context binding UI indicators #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: cursor <cursor@idnc.sk>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: cursor <cursor@idnc.sk>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
src/popup/popup.js
Outdated
|
|
||
| // Create gray button indicator for unbound state when disconnected | ||
| const unboundIndicator = '<span class="status-dot unbound" style="margin-right: 6px;"></span>'; | ||
| contextId.innerHTML = `${unboundIndicator}-`; |
There was a problem hiding this comment.
Bug: XSS Vulnerability Through Unsafe DOM Manipulation
This change introduces an XSS vulnerability by using innerHTML to insert unsanitized external data, specifically connection.context.id and wsName. This bypasses established secure DOM manipulation patterns like escapeHtml() and createSecureElement().
Co-authored-by: cursor <cursor@idnc.sk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add visual indicators (green/gray dots) to the context ID to streamline UI/UX for canvas integrations.