Skip to content

Conversation

edisile
Copy link
Contributor

@edisile edisile commented Oct 13, 2025

Done

  • moved StoreNotFound page to Publisher layout
  • refactored BrandStoreLayout into a BrandStoreRoute wrapper component
  • refactored route definitions for brand store pages

How to QA

  • log in
  • open a brand store page
    • there are no visual glitches during the "Loading" state
  • change brand ID in the URL to a random string
    • the "Store not found" page is shown
    • no visual glitches

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes WD-29593

Screenshots

@webteam-app
Copy link

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edisile edisile merged commit b412116 into merge-publisher-layouts Oct 17, 2025
9 checks passed
@edisile edisile deleted the _merge-publisher-layouts branch October 17, 2025 13:30
edisile added a commit that referenced this pull request Oct 17, 2025
* Merge publisher layouts (pt1): Portal helpers and move Brand store snaps (#5398)

* feature: add portal helpers

* chore: move brand store snaps page to Publisher layout

* fix: remove redundant fragments

* fix: better error check in useMergeRefs

* Merge publisher layouts (pt2): account details page (#5401)

* chore: move account details page  to Publisher layout

* fix: typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* chore: move brand store members page to Publisher layout (#5408)

* chore: move brand store settings page to Publisher layout (#5409)

* chore: move signing keys page to Publisher layout (#5410)

* chore: move signing keys page to Publisher layout

* fix: test

* chore: move models page to Publisher layout (#5412)

* chore: move Model details page to Publisher layout (#5413)

* chore: move Policy page to Publisher layout (#5415)

* chore: move Policy page to Publisher layout

* fix: tests

* fix: Delete policy modal button

* chore: cleanup store not found logic (#5418)

* chore: cleanup store not found logic

* fix: route for redirect when visiting /admin/:id -> /admin/:id/snaps

* chore: rename portal componen and linting

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants