chore: move Policy page to Publisher layout #5415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
edisile
force-pushed
the
_merge-publisher-layouts
branch
from
f5f211a to
0924874
Compare
|
small nit: when I click "delete policy" and whilst it's deleting, the "Delete" button is still actionable. Would be nice to disable this whilst deletion is happening |
edisile
force-pushed
the
_merge-publisher-layouts
branch
from
1360657 to
94e544a
Compare
|
@abbiesims good catch! As a drive-by I changed the layout a little bit to avoid the ugly resize when changing the modal's contents: |
edisile
added a commit
that referenced
this pull request
Oct 17, 2025
* Merge publisher layouts (pt1): Portal helpers and move Brand store snaps (#5398) * feature: add portal helpers * chore: move brand store snaps page to Publisher layout * fix: remove redundant fragments * fix: better error check in useMergeRefs * Merge publisher layouts (pt2): account details page (#5401) * chore: move account details page to Publisher layout * fix: typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: move brand store members page to Publisher layout (#5408) * chore: move brand store settings page to Publisher layout (#5409) * chore: move signing keys page to Publisher layout (#5410) * chore: move signing keys page to Publisher layout * fix: test * chore: move models page to Publisher layout (#5412) * chore: move Model details page to Publisher layout (#5413) * chore: move Policy page to Publisher layout (#5415) * chore: move Policy page to Publisher layout * fix: tests * fix: Delete policy modal button * chore: cleanup store not found logic (#5418) * chore: cleanup store not found logic * fix: route for redirect when visiting /admin/:id -> /admin/:id/snaps * chore: rename portal componen and linting --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
How to QA
Testing
Issue / Card
Fixes WD-29284
Screenshots
BEFORE:
AFTER:
