-
Notifications
You must be signed in to change notification settings - Fork 116
Remove legacy run script and outdated documentation #5411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copilot is not a collaborator of the repo |
Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
@copilot It seems that the BRANDSTORES.md file that was referencing the run script is all outdated as well. Remove it, and any references to it. |
Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
@Lukewh This seems to have worked (with a bit of additional nudging in comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the legacy run
script and associated outdated documentation to standardize on the modern dotrun
tool for local development. The project has evolved to use dotrun
as the primary development tool, making the 615-line Docker-based run
script obsolete.
Key changes:
- Removes the entire legacy
run
script (615 lines) that wrapped Docker commands - Eliminates the
BRANDSTORES.md
file and all brand stores documentation - Updates
.github/copilot-instructions.md
to remove references to the oldrun
script
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
run |
Complete removal of the 615-line legacy bash script for Docker-based development |
README.md |
Removed outdated "Brand stores" and "Deploy" sections that referenced the old script |
BRANDSTORES.md |
Deleted entire brand stores documentation file |
.github/copilot-instructions.md |
Updated to remove ./run serve references and brand stores documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM - good nudging, but seems to have done the thing
Overview
This PR removes the legacy
run
script that was previously used for Docker-based local development, along with outdated documentation sections from README.md. The project has since migrated to using thedotrun
tool for local development, making the oldrun
script obsolete. Several documentation sections are now handled differently and the old documentation is no longer relevant.Changes
Removed
run
script - Removed the 530-line bash script that wrapped Docker commands for local developmentBRANDSTORES.md
- Removed outdated brand stores documentation fileUpdated Documentation
./run serve
from the "Running the App" sectionrun (Docker wrapper)
andBRANDSTORES.md
from the Key Files listBRANDSTORES.md
from the "Verify Best Practices" sectionRationale
The
run
script was generated bygenerator-canonical-webteam@3.4.3
and provided Docker-based development workflow commands. However, the project now usesdotrun
as the standard tool for local development, which is:The brand stores documentation (
BRANDSTORES.md
file and related sections in README.md) was outdated and referenced the oldrun
script. Since dedicated stores are now handled differently, all brand stores documentation has been removed. The Deploy section in README.md was also outdated and has been removed to keep documentation current and relevant.Verification
Performed a comprehensive search across the codebase to ensure all references to
./run
,BRANDSTORES.md
, and brand stores have been removed. The project now consistently referencesdotrun
for all local development workflows.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.