Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 9, 2025

Overview

This PR removes the legacy run script that was previously used for Docker-based local development, along with outdated documentation sections from README.md. The project has since migrated to using the dotrun tool for local development, making the old run script obsolete. Several documentation sections are now handled differently and the old documentation is no longer relevant.

Changes

Removed

  • run script - Removed the 530-line bash script that wrapped Docker commands for local development
  • BRANDSTORES.md - Removed outdated brand stores documentation file
  • Brand stores section from README.md - Removed the entire "Brand stores" section as dedicated stores are now handled differently
  • Deploy section from README.md - Removed the outdated "Deploy" section and reference to deployment config folder

Updated Documentation

  • README.md - Removed the Brand stores section, Deploy section, and reference to the outdated BRANDSTORES.md file
  • .github/copilot-instructions.md - Updated multiple references:
    • Removed ./run serve from the "Running the App" section
    • Removed brand stores reference from the Common Tasks section
    • Removed run (Docker wrapper) and BRANDSTORES.md from the Key Files list
    • Removed BRANDSTORES.md from the "Verify Best Practices" section

Rationale

The run script was generated by generator-canonical-webteam@3.4.3 and provided Docker-based development workflow commands. However, the project now uses dotrun as the standard tool for local development, which is:

  • More modern and actively maintained
  • Documented as the recommended approach in README.md
  • Already used throughout the CI/CD pipelines

The brand stores documentation (BRANDSTORES.md file and related sections in README.md) was outdated and referenced the old run script. Since dedicated stores are now handled differently, all brand stores documentation has been removed. The Deploy section in README.md was also outdated and has been removed to keep documentation current and relevant.

Verification

Performed a comprehensive search across the codebase to ensure all references to ./run, BRANDSTORES.md, and brand stores have been removed. The project now consistently references dotrun for all local development workflows.

Original prompt

In the codebase we still have a legacy run script that we used to run the project in dev environment. This has later been replaced with using dotrun tool.

Remove the old run script, and find and update any references in the code or documentation to it, to use the dotrun command instead.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI assigned Copilot and bartaz Oct 9, 2025
@webteam-app
Copy link

Copilot is not a collaborator of the repo

Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Remove legacy run script and update references to dotrun Remove legacy run script and update all references to use dotrun Oct 9, 2025
@Copilot Copilot AI requested a review from bartaz October 9, 2025 13:59
Copilot finished work on behalf of bartaz October 9, 2025 13:59
@bartaz
Copy link
Member

bartaz commented Oct 9, 2025

@copilot It seems that the BRANDSTORES.md file that was referencing the run script is all outdated as well. Remove it, and any references to it.

Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
@Copilot
Copy link
Contributor Author

Copilot AI commented Oct 9, 2025

@copilot It seems that the BRANDSTORES.md file that was referencing the run script is all outdated as well. Remove it, and any references to it.

Done. Removed BRANDSTORES.md and all references to it in README.md and .github/copilot-instructions.md (commit 8b01907).

@Copilot Copilot AI changed the title Remove legacy run script and update all references to use dotrun Remove legacy run script and outdated BRANDSTORES.md documentation Oct 9, 2025
Copilot finished work on behalf of bartaz October 9, 2025 14:17
Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
@Copilot Copilot AI changed the title Remove legacy run script and outdated BRANDSTORES.md documentation Remove legacy run script and outdated brand stores documentation Oct 9, 2025
@Copilot Copilot AI requested a review from bartaz October 9, 2025 14:27
Copilot finished work on behalf of bartaz October 9, 2025 14:27
Co-authored-by: bartaz <83575+bartaz@users.noreply.github.com>
@Copilot Copilot AI changed the title Remove legacy run script and outdated brand stores documentation Remove legacy run script and outdated documentation Oct 9, 2025
@Copilot Copilot AI requested a review from bartaz October 9, 2025 14:59
Copilot finished work on behalf of bartaz October 9, 2025 14:59
@bartaz bartaz requested a review from Lukewh October 9, 2025 15:53
@bartaz
Copy link
Member

bartaz commented Oct 9, 2025

@Lukewh This seems to have worked (with a bit of additional nudging in comments).

@bartaz bartaz marked this pull request as ready for review October 9, 2025 15:55
@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 15:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the legacy run script and associated outdated documentation to standardize on the modern dotrun tool for local development. The project has evolved to use dotrun as the primary development tool, making the 615-line Docker-based run script obsolete.

Key changes:

  • Removes the entire legacy run script (615 lines) that wrapped Docker commands
  • Eliminates the BRANDSTORES.md file and all brand stores documentation
  • Updates .github/copilot-instructions.md to remove references to the old run script

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
run Complete removal of the 615-line legacy bash script for Docker-based development
README.md Removed outdated "Brand stores" and "Deploy" sections that referenced the old script
BRANDSTORES.md Deleted entire brand stores documentation file
.github/copilot-instructions.md Updated to remove ./run serve references and brand stores documentation

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - good nudging, but seems to have done the thing

@bartaz bartaz merged commit 97e3d50 into main Oct 16, 2025
13 checks passed
@bartaz bartaz deleted the copilot/remove-old-run-script branch October 16, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants