Skip to content

Conversation

edisile
Copy link
Contributor

@edisile edisile commented Oct 9, 2025

big diff because indentation changes

Done

  • moved brand store settings to Publisher layout

How to QA

  • log in
  • visit the settings page for a brand store
    • there should be no visual glitches

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes WD-29281

Screenshots

@webteam-app
Copy link

@alvaromateo alvaromateo self-requested a review October 9, 2025 09:13
Copy link
Contributor

@alvaromateo alvaromateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edisile edisile merged commit 097beaa into merge-publisher-layouts Oct 9, 2025
9 checks passed
@edisile edisile deleted the _merge-publisher-layouts branch October 9, 2025 10:13
@edisile edisile mentioned this pull request Oct 9, 2025
2 tasks
edisile added a commit that referenced this pull request Oct 17, 2025
* Merge publisher layouts (pt1): Portal helpers and move Brand store snaps (#5398)

* feature: add portal helpers

* chore: move brand store snaps page to Publisher layout

* fix: remove redundant fragments

* fix: better error check in useMergeRefs

* Merge publisher layouts (pt2): account details page (#5401)

* chore: move account details page  to Publisher layout

* fix: typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* chore: move brand store members page to Publisher layout (#5408)

* chore: move brand store settings page to Publisher layout (#5409)

* chore: move signing keys page to Publisher layout (#5410)

* chore: move signing keys page to Publisher layout

* fix: test

* chore: move models page to Publisher layout (#5412)

* chore: move Model details page to Publisher layout (#5413)

* chore: move Policy page to Publisher layout (#5415)

* chore: move Policy page to Publisher layout

* fix: tests

* fix: Delete policy modal button

* chore: cleanup store not found logic (#5418)

* chore: cleanup store not found logic

* fix: route for redirect when visiting /admin/:id -> /admin/:id/snaps

* chore: rename portal componen and linting

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants