feat: updates rss feed #5402
feat: updates rss feed #5402
Conversation
Demo
Jenkins 
demos.haus 
There was a problem hiding this comment.
Pull Request Overview
This PR adds RSS feed functionality to the Snapcraft webapp, allowing users to get recently updated snaps through an RSS feed endpoint.
- Implements a new RSS feed generator using feedgen library for recently updated snaps
- Adds a
/feeds/updatesendpoint that accepts size and page parameters - Includes comprehensive test coverage for both successful API responses and error handling
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| webapp/feeds/feeds.py | New module implementing RSS feed generation with API integration and error handling |
| webapp/app.py | Registers the feeds blueprint to enable the RSS endpoints |
| tests/tests_feeds.py | Comprehensive test suite covering successful feed generation and API error scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
webapp/feeds/feeds.py
Outdated
|
|
||
| except Exception as e: | ||
| flask.current_app.logger.error(f"Failed to add snap to RSS feed: {e}") | ||
| raise |
There was a problem hiding this comment.
The raise statement will halt processing of all remaining snaps when one fails. Consider using continue instead to skip problematic snaps and still generate a feed with the valid ones.
| raise | |
| continue |
Copilot uses AI. Check for mistakes.
tests/tests_feeds.py
Outdated
| content = response.get_data(as_text=True) | ||
| self.assertIn('<?xml version="1.0" encoding="UTF-8"?>', content) | ||
| self.assertIn('<rss version="2.0">', content) | ||
| self.assertIn('<title>Snapcraft – recently updated applications</title>', content) |
There was a problem hiding this comment.
Test assertion expects title 'Snapcraft – recently updated applications' but the actual feed title is 'Snapcraft - recently updated Snaps' (line 62 in feeds.py). The test will fail due to this mismatch.
Copilot uses AI. Check for mistakes.
tests/tests_feeds.py
Outdated
| content = response.get_data(as_text=True) | ||
| self.assertIn('<?xml version="1.0" encoding="UTF-8"?>', content) | ||
| self.assertIn('<rss version="2.0">', content) | ||
| self.assertIn('<title>Snapcraft – recently updated applications</title>', content) |
There was a problem hiding this comment.
Test assertion expects title 'Snapcraft – recently updated applications' but the actual feed title is 'Snapcraft - recently updated Snaps' (line 62 in feeds.py). The test will fail due to this mismatch.
Copilot uses AI. Check for mistakes.
steverydz
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
5 participants
Done
/feed/updatesHow to QA
https://snapcraft-io-5402.demos.haus/feeds/updatesTesting