Merge publisher layouts (pt2): account details page #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the account details page from BrandStoreLayout to PublisherLayout as part of consolidating publisher layouts. The changes remove the hardcoded navigation and main container structure from the AccountDetails component and move the route from the brand store section to the publisher section.
Key changes:
- Removed hardcoded navigation and layout wrapper from AccountDetails component
- Moved account details route from BrandStoreLayout to PublisherLayout in routing configuration
- Fixed code formatting and indentation throughout the component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| static/js/publisher/pages/AccountDetails/AccountDetails.tsx | Removed Navigation import and layout wrapper, cleaned up formatting |
| static/js/publisher/index.tsx | Moved account details route from brand store to publisher layout section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
steverydz
approved these changes
Oct 8, 2025
steverydz
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: Code needed
Review: QA needed
labels
edisile
added a commit
that referenced
this pull request
Oct 17, 2025
* Merge publisher layouts (pt1): Portal helpers and move Brand store snaps (#5398) * feature: add portal helpers * chore: move brand store snaps page to Publisher layout * fix: remove redundant fragments * fix: better error check in useMergeRefs * Merge publisher layouts (pt2): account details page (#5401) * chore: move account details page to Publisher layout * fix: typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: move brand store members page to Publisher layout (#5408) * chore: move brand store settings page to Publisher layout (#5409) * chore: move signing keys page to Publisher layout (#5410) * chore: move signing keys page to Publisher layout * fix: test * chore: move models page to Publisher layout (#5412) * chore: move Model details page to Publisher layout (#5413) * chore: move Policy page to Publisher layout (#5415) * chore: move Policy page to Publisher layout * fix: tests * fix: Delete policy modal button * chore: cleanup store not found logic (#5418) * chore: cleanup store not found logic * fix: route for redirect when visiting /admin/:id -> /admin/:id/snaps * chore: rename portal componen and linting --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
big diff because of the indentation
Done
How to QA
Testing
Issue / Card
Fixes WD-29279
Screenshots