-
Notifications
You must be signed in to change notification settings - Fork 116
feat(ui): Add download size display to channel table (#1864) #5353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gajeshbhat is not a collaborator of the repo |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5353 +/- ##
==========================================
- Coverage 66.80% 60.46% -6.34%
==========================================
Files 113 224 +111
Lines 3714 5039 +1325
Branches 965 747 -218
==========================================
+ Hits 2481 3047 +566
- Misses 1098 1768 +670
- Partials 135 224 +89 🚀 New features to boost your workflow:
|
fc789e2
to
0121168
Compare
Thanks @gajeshbhat. I'll pass it through copilot first and we'll add it to our maintenance review list. As this is not a bug fix, but a new feature with a UI change, we'll also get a UX to review it, to confirm if the approach is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a "Download Size" column to the channel table in the snap details page, allowing users to see package sizes for each channel to make informed decisions on metered connections.
- Adds a new column displaying download sizes in human-readable format (MB, GB) between Version and Published columns
- Implements size formatting utility function using decimal (1000-based) units
- Includes responsive design hiding the column on mobile/tablet views
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/store/tests_details.py | Adds unit test verifying size data inclusion in channel map and HTML output |
templates/store/snap-details/_channel_map.html | Updates table header and row template to include Download Size column |
static/js/public/snap-details/channelMap.ts | Adds size property to interface and formatSize utility function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thank you for taking a look at this @bartaz . Copilot comments were minor, and I have replied to them and likely won't require a code change. No worries about the time, I understand that you folks are busy with higher priority items. Let's also get the clear from UX. Happy to wait. Please feel free to let me know if you have any questions for me. Cheers. |
fb2071d
to
a712bb1
Compare
a712bb1
to
719e756
Compare
- Add "Download Size" column to channel map table showing per-channel package sizes - Implement human-readable size formatting (B, kB, MB, GB, TB) in JavaScript - Update ChannelData TypeScript interface to include size field - Add responsive design (hidden on mobile screens) - Include comprehensive unit tests for size display functionality Addresses user need for bandwidth awareness on metered connections by showing accurate download sizes for each channel, since different channels can have different package sizes. Fixes canonical#1864
719e756
to
a1792c4
Compare
Done
This addresses user need for bandwidth awareness on metered connections by showing accurate download sizes for each channel, since different channels can have different package sizes.
How to QA
feat/show-package-size-1864
and run the server locally usingdotrun
/firefox
,/code
,/discord
)Testing
test_package_size_in_channel_map
that verifies size data is correctly included in channel map data structure and HTML outputIssue / Card
Fixes #1864
Screenshots
Screenshots and a screencast have been added below showing the new Download Size column in the channel table across different snap packages.
Screencast of me running the changes locally on a server and Download Sizes column working
Screencast-Downoad-Size-Snapcraft-1864.webm