-
Notifications
You must be signed in to change notification settings - Fork 116
Explore page #5179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore page #5179
Conversation
b4fb4c3
to
3d5c694
Compare
c51114c
to
93d04e8
Compare
c48b364
to
ec57d96
Compare
f83f84d
to
7f6ca5d
Compare
0abef03
to
799470b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its very nice. but I agree with you both that this should be server side rendered 👍
<> | ||
{snaps.recent && ( | ||
<Strip shallow className="u-no-padding--bottom"> | ||
<RecommendationsSection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, from my understanding, @0-luke wants this to be more dynamic (i.e, if I want to change the title, I don't need to open a PR). The service itself still isn't ready for this, but thought I'd mention it so that its in mind when the code is changed to be server side
4f81e73
to
488df27
Compare
@leiaru-c I've addressed the key points we talked about with the design. Could you please take another look?
|
* feat: Add editorial slices to explore page * Update static/js/store/hooks/useCategories.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update static/js/store/pages/Explore/EditorialSection.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove unnecessary checks in explore page loading state --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
e149924
to
6af2a12
Compare
Checked and it's good to go for me. Looking forward to the next iteration :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Done
Adds explore page
Note: The content will be different from the design, and in the case of slices it is intentionally duplicated as currently there is only one slice which only contains two snaps
How to QA
Testing
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-20973