Skip to content

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jun 26, 2025

Done

Adds explore page

Note: The content will be different from the design, and in the case of slices it is intentionally duplicated as currently there is only one slice which only contains two snaps

How to QA

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-20973

@webteam-app
Copy link

@steverydz steverydz force-pushed the explore-page branch 3 times, most recently from b4fb4c3 to 3d5c694 Compare July 4, 2025 13:48
@steverydz steverydz force-pushed the explore-page branch 4 times, most recently from c51114c to 93d04e8 Compare July 16, 2025 08:41
@steverydz steverydz changed the title WIP: Explore page Explore page Jul 16, 2025
@steverydz steverydz marked this pull request as ready for review July 16, 2025 09:34
@steverydz steverydz force-pushed the explore-page branch 3 times, most recently from c48b364 to ec57d96 Compare July 22, 2025 13:37
@steverydz steverydz force-pushed the explore-page branch 8 times, most recently from f83f84d to 7f6ca5d Compare July 30, 2025 10:21
@steverydz steverydz force-pushed the explore-page branch 5 times, most recently from 0abef03 to 799470b Compare August 1, 2025 14:30
Copy link
Contributor

@M7mdisk M7mdisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its very nice. but I agree with you both that this should be server side rendered 👍

<>
{snaps.recent && (
<Strip shallow className="u-no-padding--bottom">
<RecommendationsSection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, from my understanding, @0-luke wants this to be more dynamic (i.e, if I want to change the title, I don't need to open a PR). The service itself still isn't ready for this, but thought I'd mention it so that its in mind when the code is changed to be server side

@leiaru-c
Copy link

leiaru-c commented Oct 6, 2025

Here are points I think need updates:

  • Overall layout:
    The spacing between elements seems to be a bit tight after titles.
image
  • Search bar empty state:
reviewsnapcraft1 The empty state should say "Search snap store" to stay aligned with [charmhub](https://charmhub.io/) or "Search thousands of apps" to stay true to designs. I think that searching Snapcraft is misleading, there is nothing to search on snapcraft, only on snapcraft.io or the snap store, and snapstore.io could refer to other marketing pages, not apps.
  • Categories section:
image 1/ Without any illustration, it looks quite bare. I can check with the visual team on what to do here if we cannot use icons. 2/ The Featured category is missing in the demo (Yellow).
  • Top rated vs most popular, most popular vs trending snaps:
    The wording in both these categories is confusing.
    In the design, the titles say "top rated" versus "most popular", so my guess is that it means most liked/high rated snaps versus most downloaded snaps.
    In the demo, "most popular" versus "trending snaps" sound too similar, it makes me think that they both are based on the number of downloads.
image image We need to clarify what criteria we use to show results for these categories.
  • Game section:
    The game spotlight is very good, can't we have it?
image

These are not show stoppers, but worth raising:

  • Banners:
    The banners with selection of apps for specific use cases are nice, they add some color and spotlight useful apps. I am assuming it is not in the demo because it is not feasible short term, but would be good to have.
image
  • See all link for "recently updated snaps":
image I don't know if seeing all recently updated snap is possible, but there was a link in the intial designs.
  • Categories section:
image 3/ The copy style guide specifies that we should use small caps in titles, not capitalise words. That being said, I know that the categories themselves in filters are capitalised, so imo, there are 3 options: - Leave as is: if we go for consistency and can't modify the filters, it's ok to keep the capitalisation as is. - Only modify the copy on the page, leave the filters as is: if we consider that the category titles are not the same as filters, then removing the caps would be good. - Modify the copy and update the filters: And if we want consistency with copy guidelines and the way that filters are formatted, it would be good to remove the second word capitalisation in the filters as well.
  • Top rated vs most popular, most popular vs trending snaps:
    In addition to feedback earlier, I think that these two concepts (most downloads, and best ratings) overlap quite a bit and might not provide as much value. In the demo, two apps overlap, which is not the end of the world but is not all that great either. A selection of popular snaps per top categories might be more interesting in the future?
image
  • Ubuntu community section:
    Also really nice, what would need to be done to have that section in asap?
image

@steverydz
Copy link
Contributor Author

@leiaru-c I've addressed the key points we talked about with the design. Could you please take another look?

  • Fixed spacing between sections and headings
  • Updated the placeholder text of the search box
  • The capitalisation for the categories comes from the API so would need to be changed at that level
  • The titles, e.g. Most popular etc. come from the recommendations service so can be updated there along with the chosen snaps

steverydz and others added 11 commits October 13, 2025 13:03
* feat: Add editorial slices to explore page

* Update static/js/store/hooks/useCategories.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update static/js/store/pages/Explore/EditorialSection.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Remove unnecessary checks in explore page loading state

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@leiaru-c
Copy link

Checked and it's good to go for me. Looking forward to the next iteration :)

@abbiesims abbiesims self-requested a review October 15, 2025 10:30
Copy link
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@steverydz steverydz merged commit b594d3f into main Oct 15, 2025
13 checks passed
@steverydz steverydz deleted the explore-page branch October 15, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants