-
Notifications
You must be signed in to change notification settings - Fork 116
WIP: Snap CVEs POC #5139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bartaz
wants to merge
7
commits into
main
Choose a base branch
from
poc-cves
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Snap CVEs POC #5139
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
93f436f
POC: quick prototype of showing snap CVE data in a table with select …
bartaz dc81003
Add expanding table
bartaz 1c825c1
Get flattened list of affected binaries, paginater on client side
bartaz 20eabcb
Added custom styling of several CVE table cells
bartaz d0eaa85
Update CVEs table styling
bartaz 9700d40
Add label to revision select
bartaz 43b4668
Add vulnerabilities tab
bartaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,55 +1,66 @@ | ||
import { Link } from "react-router-dom"; | ||
import { Tabs } from "@canonical/react-components"; | ||
|
||
import { usePublisher } from "../../hooks"; | ||
|
||
type Props = { | ||
activeTab: string; | ||
snapName: string | undefined; | ||
}; | ||
|
||
function SectionNav({ activeTab, snapName }: Props): React.JSX.Element { | ||
return ( | ||
<Tabs | ||
listClassName="u-no-margin--bottom" | ||
links={[ | ||
{ | ||
label: "Listing", | ||
active: activeTab === "listing" || !activeTab, | ||
to: `/${snapName}/listing`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Builds", | ||
active: activeTab === "builds", | ||
to: `/${snapName}/builds`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Releases", | ||
active: activeTab === "releases", | ||
to: `/${snapName}/releases`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Metrics", | ||
active: activeTab === "metrics", | ||
to: `/${snapName}/metrics`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Publicise", | ||
active: activeTab === "publicise", | ||
to: `/${snapName}/publicise`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Settings", | ||
active: activeTab === "settings", | ||
to: `/${snapName}/settings`, | ||
component: Link, | ||
}, | ||
]} | ||
/> | ||
); | ||
const { data: publisherData } = usePublisher(); | ||
|
||
const links = [ | ||
{ | ||
label: "Listing", | ||
active: activeTab === "listing" || !activeTab, | ||
to: `/${snapName}/listing`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Builds", | ||
active: activeTab === "builds", | ||
to: `/${snapName}/builds`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Releases", | ||
active: activeTab === "releases", | ||
to: `/${snapName}/releases`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Metrics", | ||
active: activeTab === "metrics", | ||
to: `/${snapName}/metrics`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Publicise", | ||
active: activeTab === "publicise", | ||
to: `/${snapName}/publicise`, | ||
component: Link, | ||
}, | ||
{ | ||
label: "Settings", | ||
active: activeTab === "settings", | ||
to: `/${snapName}/settings`, | ||
component: Link, | ||
}, | ||
]; | ||
|
||
// TODO: verify if the snap has CVE data before adding the link | ||
if (publisherData?.publisher?.is_canonical) { | ||
links.splice(3, 0, { | ||
label: "Vulnerabilities", | ||
active: activeTab === "vulnerabilities", | ||
to: `/${snapName}/cves`, | ||
component: Link, | ||
}); | ||
} | ||
|
||
return <Tabs listClassName="u-no-margin--bottom" links={links} />; | ||
} | ||
|
||
export default SectionNav; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { useQuery } from "react-query"; | ||
|
||
function useCves() { | ||
return useQuery({ | ||
queryKey: ["cves"], | ||
queryFn: async () => { | ||
const response = await fetch(`/api/docker/3213/cves`); | ||
|
||
if (!response.ok) { | ||
throw new Error("Unable to fetch CVEs"); | ||
} | ||
|
||
const responseData = await response.json(); | ||
|
||
return responseData; | ||
}, | ||
}); | ||
} | ||
|
||
export default useCves; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fetch path is hard-coded to
/api/docker/3213/cves
; parameterize or remove this placeholder to avoid confusion and support multiple snaps.Copilot uses AI. Check for mistakes.