Skip to content

fix: self serve tracks metadata error #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: self serve tracks metadata error #4876

merged 1 commit into from
Oct 9, 2024

Conversation

abbiesims
Copy link
Contributor

@abbiesims abbiesims commented Oct 9, 2024 •
edited
Loading

Done

  • Refactors fetching of track guardrails to use useQuery instead of useEffect
  • Should mean packageMetadata fetch does not run twice and should make the "request"/"add" track buttons more stable

How to QA

Check the following 3 scenarios:

  1. Your own snap (or one you are a collaborator on) that does not have guardrails
    a. You should see "Request track" in the tracks dropdown

  2. Your own snap (or one you are a collaborator on) that has guardrails
    a. You should see "Add track" in the tracks dropdown

  3. A snap that you do not have any permissions for
    a. You should not see any additional buttons in the tracks dropdown

Testing

  • This PR has tests: fixed tests
  • No testing required (explain why):

Issue / Card

Fixes WD-15763

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@abbiesims abbiesims force-pushed the WD-15763-fix-self-serve-package-metadata branch from 8cef8eb to 8cd38e8 Compare October 9, 2024 12:10
Lukewh
Lukewh approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@abbiesims abbiesims merged commit c86f68c into main Oct 9, 2024
11 checks passed
@abbiesims abbiesims deleted the WD-15763-fix-self-serve-package-metadata branch October 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukewh Lukewh Lukewh approved these changes

Assignees

No one assigned

Labels

Review: Code +1 Review: QA +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abbiesims @webteam-app @Lukewh