Skip to content

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Oct 8, 2024

Done

Replaced the builds template view with an endpoint to get builds data and added an endpoint to get GitHub repo data which is necessary for determining which state to show the user and connecting the repo.

This change will break the builds UI which is fine as it is being refactored and subsequent PRs will address this.

This will have to be tested locally as you'll need your GitHub tokens in your .env.local file.

GITHUB_CLIENT_ID=whatever
GITHUB_CLIENT_SECRET=whatever

You can set those here if you don't have them already: https://github.com/settings/applications/new

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): Deleting old views

@webteam-app
Copy link

@steverydz steverydz merged commit 3014520 into publisher-react-app Oct 8, 2024
8 checks passed
@steverydz steverydz deleted the create-endpoints-for-publisher-builds branch October 8, 2024 12:32
steverydz added a commit that referenced this pull request Jan 6, 2025
* feat: Move publicise into publisher app (#4844)

* feat: Move settings into publisher app (#4847)

* Wd 14634 metrics page (#4851)

* feat: migrate metrics page to react

* Wd 15262 improve performance of metric page (#4863)

* feat: added downsampling and pagination

* chore: Move listing page into publisher app (#4865)

* feat: add breadcrumb nav to the metrics page (#4871)

* feat: Create endpoints to get repo data and builds data (#4873)

* feat: update badge sources (#4892)

* feat: Add builds section to publisher pages (#4890)

Simplify step 1

Simplify step 2

Simplify step 3

Simplify step 4

Simplify step 5

* feat: Move releases section into the publisher app (#4902)

* fix: Fix publicise disabled notification (#4911)

* fix: Fix issue with saving settings when navigating from listing (#4913)

* fix: Fix publicise view for private snaps (#4914)

* Rebase

* fix: Fix issues with tour styles (#4916)

* fix: Fix code linting errors in publisher app (#4921)

* fix: Fix a11y errors in builds section (#4922)

* fix: Fix publisher a11y errors in the publicise cards section (#4923)

* fix: Fix publisher a11y errors in publicise badges section (#4924)

* fix: Fix publisher a11y errors in publicise buttons section (#4925)

* fix: Fix publisher a11y errors in settings section (#4926)

* fix: Fix a11y errors in license search (#4928)

* fix: Fix a11y errors in search autocomplete (#4929)

* chore: Remove legacy publisher JS (#4930)

fix: Ignore metrics TS errors for now (#4933)

fix: Fix checkbox values resetting in publisher settings form (#4937)

fix: Fix primary website field clearing on revert (#4938)

fix: Make sure Edit button on preview page closes current tab (#4939)

fix: Fix deleting icon or banner not activating save button (#4940)

fix: render selected language in HTML and markdown snippets (#4942)

fix: remove extra whitespace in embeddable card (#4943)

fix: Fix missing contact links in preview (#4944)

fix: Fix preview card button being squashed (#4945)

fix: Fix display of releases table (#4946)

fix: Add loading state to single build page (#4947)

fix: ensure markdown is rendered correctly (#4948)

fix: build page showing stale data while fetching logs (#4949)

fix: Fix missing banner in listing publisher page (#4950)

fix: Fix form not resetting when making changes to images (#4952)

---------

Co-authored-by: ilayda-cp <ilayda.cavusoglupars@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants