-
Notifications
You must be signed in to change notification settings - Fork 116
Metrics demo react #4868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics demo react #4868
Conversation
* feat: migrate metrics page to react
* feat: added downsampling and pagination
trending: boolean; | ||
}; | ||
SNAP_SETTINGS_DATA: { | ||
blacklist_countries: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist
may be insensitive, use denylist
, blocklist
instead
}; | ||
SNAP_SETTINGS_DATA: { | ||
blacklist_countries: string[]; | ||
blacklist_country_keys: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist
may be insensitive, use denylist
, blocklist
instead
update_metadata_on_release: boolean; | ||
visibility: string; | ||
visibility_locked: boolean; | ||
whitelist_countries: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist
may be insensitive, use allowlist
instead
visibility: string; | ||
visibility_locked: boolean; | ||
whitelist_countries: string[]; | ||
whitelist_country_keys: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist
may be insensitive, use allowlist
instead
}; | ||
|
||
export type SettingsData = { | ||
blacklist_countries: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist
may be insensitive, use denylist
, blocklist
instead
update_metadata_on_release: {% if update_metadata_on_release %}{{ update_metadata_on_release|tojson }}{% else %}false{% endif %}, | ||
private: {% if private %}{{ private|tojson }}{% else %}false{% endif %}, | ||
unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %}, | ||
whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist
may be insensitive, use allowlist
instead
update_metadata_on_release: {% if update_metadata_on_release %}{{ update_metadata_on_release|tojson }}{% else %}false{% endif %}, | ||
private: {% if private %}{{ private|tojson }}{% else %}false{% endif %}, | ||
unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %}, | ||
whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist
may be insensitive, use allowlist
instead
private: {% if private %}{{ private|tojson }}{% else %}false{% endif %}, | ||
unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %}, | ||
whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %}, | ||
blacklist_countries: {% if blacklist_country_codes %}{{ blacklist_country_codes|tojson }}{% else %}[]{% endif %}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist
may be insensitive, use denylist
, blocklist
instead
private: {% if private %}{{ private|tojson }}{% else %}false{% endif %}, | ||
unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %}, | ||
whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %}, | ||
blacklist_countries: {% if blacklist_country_codes %}{{ blacklist_country_codes|tojson }}{% else %}[]{% endif %}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist
may be insensitive, use denylist
, blocklist
instead
private: {% if private %}{{ private|tojson }}{% else %}false{% endif %}, | ||
unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %}, | ||
whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %}, | ||
blacklist_countries: {% if blacklist_country_codes %}{{ blacklist_country_codes|tojson }}{% else %}[]{% endif %}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist
may be insensitive, use denylist
, blocklist
instead
<Col size={10}> | ||
<p> | ||
<img | ||
src={`https://snapcraft.io/static/images/badges/${selectedLanguage}/snap-store-black.svg`} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
<Col size={10}> | ||
<p> | ||
<img | ||
src={`https://snapcraft.io/static/images/badges/${selectedLanguage}/snap-store-white.svg`} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Done
How to QA
Testing
Issue / Card
Fixes #
Screenshots