chore: Move listing page into publisher app #4865

steverydz · 2024-10-03T14:27:24Z

Done

Moved the listing page into the publisher app.

The majority of this work is moving and renaming files, whilst also updating routes, renaming variables and probs so the components work as expected. There are no changes to functionality.

How to QA

Go to https://snapcraft-io-4865.demos.haus/<SNAP_NAME>/listing
Check that it is in the application layout
Check that you can still save changes

Testing

This PR has tests
No testing required (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-14633

webteam-app · 2024-10-03T14:27:28Z

Demo

Jenkins

demos.haus

github-actions · 2024-10-03T14:27:44Z

templates/store/publisher.html

+    update_metadata_on_release: {% if update_metadata_on_release %}{{ update_metadata_on_release|tojson }}{% else %}false{% endif %},
+    private: {% if private %}{{ private|tojson }}{% else %}false{% endif %},
+    unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %},
+    whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %},


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] whitelist may be insensitive, use allowlist instead

github-actions · 2024-10-03T14:27:44Z

templates/store/publisher.html

+    update_metadata_on_release: {% if update_metadata_on_release %}{{ update_metadata_on_release|tojson }}{% else %}false{% endif %},
+    private: {% if private %}{{ private|tojson }}{% else %}false{% endif %},
+    unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %},
+    whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %},


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] whitelist may be insensitive, use allowlist instead

github-actions · 2024-10-03T14:27:45Z

templates/store/publisher.html

+    update_metadata_on_release: {% if update_metadata_on_release %}{{ update_metadata_on_release|tojson }}{% else %}false{% endif %},
+    private: {% if private %}{{ private|tojson }}{% else %}false{% endif %},
+    unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %},
+    whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %},


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] whitelist may be insensitive, use allowlist instead

github-actions · 2024-10-03T14:27:45Z

templates/store/publisher.html

+    private: {% if private %}{{ private|tojson }}{% else %}false{% endif %},
+    unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %},
+    whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %},
+    blacklist_countries: {% if blacklist_country_codes %}{{ blacklist_country_codes|tojson }}{% else %}[]{% endif %},


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] blacklist may be insensitive, use denylist, blocklist instead

github-actions · 2024-10-03T14:27:45Z

templates/store/publisher.html

+    private: {% if private %}{{ private|tojson }}{% else %}false{% endif %},
+    unlisted: {% if unlisted %}{{ unlisted|tojson }}{% else %}false{% endif %},
+    whitelist_countries: {% if whitelist_country_codes %}{{ whitelist_country_codes|tojson }}{% else %}[]{% endif %},
+    blacklist_countries: {% if blacklist_country_codes %}{{ blacklist_country_codes|tojson }}{% else %}[]{% endif %},


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] blacklist may be insensitive, use denylist, blocklist instead

github-actions · 2024-10-03T14:27:45Z

static/js/publisher-pages/types/index.d.ts

 };
+
+export type SettingsData = {
+  blacklist_countries: string[];


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] blacklist may be insensitive, use denylist, blocklist instead

github-actions · 2024-10-03T14:27:46Z

static/js/publisher-pages/types/index.d.ts

+
+export type SettingsData = {
+  blacklist_countries: string[];
+  blacklist_country_keys: string;


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] blacklist may be insensitive, use denylist, blocklist instead

github-actions · 2024-10-03T14:27:46Z

static/js/publisher-pages/types/index.d.ts

+  update_metadata_on_release: boolean;
+  visibility: string;
+  visibility_locked: boolean;
+  whitelist_countries: string[];


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] whitelist may be insensitive, use allowlist instead

github-actions · 2024-10-03T14:27:46Z

static/js/publisher-pages/types/index.d.ts

+  visibility: string;
+  visibility_locked: boolean;
+  whitelist_countries: string[];
+  whitelist_country_keys: string;


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] whitelist may be insensitive, use allowlist instead

github-actions · 2024-10-03T14:27:46Z

static/js/publisher-pages/types/index.d.ts

+  issues: { url: string }[];
+  primary_website: string;
+  public_metrics_enabled: boolean;
+  public_metrics_blacklist: string[];


[Inclusive naming check] _{reported by reviewdog 🐶}
[warning] blacklist may be insensitive, use denylist, blocklist instead

static/js/publisher-pages/pages/Publicise/PubliciseButtons.tsx

+        <Col size={10}>
+          <p>
+            <img
+              src={`https://snapcraft.io/static/images/badges/${selectedLanguage}/snap-store-black.svg`}


static/js/publisher-pages/pages/Publicise/PubliciseButtons.tsx

+        <Col size={10}>
+          <p>
+            <img
+              src={`https://snapcraft.io/static/images/badges/${selectedLanguage}/snap-store-white.svg`}


chillkang

LGTM🚀 Just one question: is copilot integrated in our project?

* feat: Move publicise into publisher app (#4844) * feat: Move settings into publisher app (#4847) * Wd 14634 metrics page (#4851) * feat: migrate metrics page to react * Wd 15262 improve performance of metric page (#4863) * feat: added downsampling and pagination * chore: Move listing page into publisher app (#4865) * feat: add breadcrumb nav to the metrics page (#4871) * feat: Create endpoints to get repo data and builds data (#4873) * feat: update badge sources (#4892) * feat: Add builds section to publisher pages (#4890) Simplify step 1 Simplify step 2 Simplify step 3 Simplify step 4 Simplify step 5 * feat: Move releases section into the publisher app (#4902) * fix: Fix publicise disabled notification (#4911) * fix: Fix issue with saving settings when navigating from listing (#4913) * fix: Fix publicise view for private snaps (#4914) * Rebase * fix: Fix issues with tour styles (#4916) * fix: Fix code linting errors in publisher app (#4921) * fix: Fix a11y errors in builds section (#4922) * fix: Fix publisher a11y errors in the publicise cards section (#4923) * fix: Fix publisher a11y errors in publicise badges section (#4924) * fix: Fix publisher a11y errors in publicise buttons section (#4925) * fix: Fix publisher a11y errors in settings section (#4926) * fix: Fix a11y errors in license search (#4928) * fix: Fix a11y errors in search autocomplete (#4929) * chore: Remove legacy publisher JS (#4930) fix: Ignore metrics TS errors for now (#4933) fix: Fix checkbox values resetting in publisher settings form (#4937) fix: Fix primary website field clearing on revert (#4938) fix: Make sure Edit button on preview page closes current tab (#4939) fix: Fix deleting icon or banner not activating save button (#4940) fix: render selected language in HTML and markdown snippets (#4942) fix: remove extra whitespace in embeddable card (#4943) fix: Fix missing contact links in preview (#4944) fix: Fix preview card button being squashed (#4945) fix: Fix display of releases table (#4946) fix: Add loading state to single build page (#4947) fix: ensure markdown is rendered correctly (#4948) fix: build page showing stale data while fetching logs (#4949) fix: Fix missing banner in listing publisher page (#4950) fix: Fix form not resetting when making changes to images (#4952) --------- Co-authored-by: ilayda-cp <ilayda.cavusoglupars@canonical.com>

chore: Move listing page into publisher app

c1f4cfe

github-actions bot reviewed Oct 3, 2024

View reviewed changes

steverydz changed the title ~~Wd 14633 move listing page into publisher app~~ chore: Move listing page into publisher app Oct 3, 2024

steverydz added Review: Code needed Review: QA needed labels Oct 3, 2024

github-advanced-security bot found potential problems Oct 3, 2024

View reviewed changes

steverydz changed the base branch from main to publisher-react-app October 3, 2024 14:30

chillkang approved these changes Oct 3, 2024

View reviewed changes

chillkang added Review: Code +1 Review: QA +1 and removed Review: Code needed Review: QA needed labels Oct 3, 2024

steverydz merged commit 4391acc into publisher-react-app Oct 3, 2024
10 of 11 checks passed

steverydz deleted the WD-14633-move-listing-page-into-publisher-app branch October 3, 2024 15:17

steverydz added a commit that referenced this pull request Oct 8, 2024

chore: Move listing page into publisher app (#4865)

698377a

steverydz added a commit that referenced this pull request Oct 10, 2024

chore: Move listing page into publisher app (#4865)

77c5575

steverydz added a commit that referenced this pull request Oct 14, 2024

chore: Move listing page into publisher app (#4865)

8274c93

steverydz added a commit that referenced this pull request Oct 16, 2024

chore: Move listing page into publisher app (#4865)

61f9523

steverydz added a commit that referenced this pull request Oct 18, 2024

chore: Move listing page into publisher app (#4865)

51583c8

steverydz added a commit that referenced this pull request Oct 24, 2024

chore: Move listing page into publisher app (#4865)

337fd5e

steverydz added a commit that referenced this pull request Nov 22, 2024

chore: Move listing page into publisher app (#4865)

f0e694d

steverydz added a commit that referenced this pull request Dec 4, 2024

chore: Move listing page into publisher app (#4865)

9977a37

steverydz added a commit that referenced this pull request Dec 5, 2024

chore: Move listing page into publisher app (#4865)

f8d3b65

steverydz added a commit that referenced this pull request Dec 9, 2024

chore: Move listing page into publisher app (#4865)

f8dbf3f

chore: Move listing page into publisher app #4865

chore: Move listing page into publisher app #4865

Uh oh!

Conversation

steverydz commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Done

How to QA

Testing

Issue / Card

Uh oh!

webteam-app commented Oct 3, 2024

Demo

Jenkins

demos.haus

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

chillkang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

steverydz commented Oct 3, 2024 •

edited

Loading

chillkang left a comment •

edited

Loading