Skip to content

Conversation

abbiesims
Copy link
Contributor

@abbiesims abbiesims commented Sep 5, 2024

Done

Fixes #4822
Allows user to search for a snap outside of the featured snaps on initial load of the store.

How to QA

Go to https://snapcraft-io-4843.demos.haus/store and check:

  1. Initial load shows featured snaps as normal
  2. Selecting a category filters snaps correctly
  3. Deselecting a category returns UI to show Featured snaps
  4. Entering a search term allows user to search through all snaps
  5. Selecting a category with a search term filters the search to the chosen category (and vice versa)

Testing

  • This PR has tests
  • No testing required (explain why): no new features - updated existing tests

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-14710

@webteam-app
Copy link

@steverydz
Copy link
Contributor

When searching all snaps the heading is still "Featured snaps". Perhaps this should change to "All snaps" or just "Snaps"?

@abbiesims
Copy link
Contributor Author

When searching all snaps the heading is still "Featured snaps". Perhaps this should change to "All snaps" or just "Snaps"?

Nice catch 👍 will change it to just "Snaps" so that when a filter is also selected it doesn't say "All...", think that makes the most sense.

@abbiesims abbiesims force-pushed the WD-14710/fix-search-ux branch from 48e09c1 to 873e8aa Compare September 5, 2024 15:03
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abbiesims abbiesims merged commit cf0d17b into main Sep 5, 2024
8 checks passed
@abbiesims abbiesims deleted the WD-14710/fix-search-ux branch September 5, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor search UX when accessing the Snap Store via the <https://snapcraft.io/store> URL

3 participants