Skip to content

chore: Refactor publisher app #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2024
Merged

chore: Refactor publisher app #4842

merged 1 commit into from
Sep 5, 2024

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Sep 5, 2024 •
edited
Loading

Done

Refactored validation sets into the publisher app

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): Mostly just moving files

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@steverydz steverydz marked this pull request as ready for review September 5, 2024 13:39
abbiesims
abbiesims approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit 664d25c into main Sep 5, 2024
@steverydz steverydz deleted the refactor-publisher-app branch September 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbiesims abbiesims abbiesims approved these changes

Assignees

No one assigned

Labels

Review: Code +1 Review: QA +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steverydz @webteam-app @abbiesims