fix: make tls-secret-name optional for lego use #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The charm makes
tls-secret-namea mandatory configuration variable. That particular variable is used withnginx-ingress-integratorto supply a TLS certificate manually. However, the Lego charm can automate acquiring TLS certificates. Unfortunately,tls-secret-namecurrently cannot be left blank and using a dummy variable causes the ingress to get a default certificate that does not work.This PR make
tls-secret-nameoptional. This particular change has been tested via hacking the charm code manually and worked.Notes for Code Reviewers
The PR will be in draft until I can write proper tests. Unless we decide to forego tests for this change.