Skip to content

Conversation

@mertalpt
Copy link
Collaborator

Description

The charm makes tls-secret-name a mandatory configuration variable. That particular variable is used with nginx-ingress-integrator to supply a TLS certificate manually. However, the Lego charm can automate acquiring TLS certificates. Unfortunately, tls-secret-name currently cannot be left blank and using a dummy variable causes the ingress to get a default certificate that does not work.

This PR make tls-secret-name optional. This particular change has been tested via hacking the charm code manually and worked.

Notes for Code Reviewers

The PR will be in draft until I can write proper tests. Unless we decide to forego tests for this change.

@mertalpt mertalpt requested a review from a team June 12, 2025 12:45
@kelkawi-a kelkawi-a requested a review from a team June 12, 2025 12:46
@mertalpt
Copy link
Collaborator Author

@kelkawi-a Should I update the libraries? Should I write new tests for the Lego integration? We can do that later™ too.

@mertalpt mertalpt marked this pull request as ready for review June 12, 2025 13:41
@mertalpt
Copy link
Collaborator Author

Given how long it takes to run tests, I am opting to merge now write tests later. The change is very small.

@kelkawi-a
Copy link
Collaborator

@kelkawi-a Should I update the libraries? Should I write new tests for the Lego integration? We can do that later™ too.

Library updates can be a separate PR. No need for Lego charm tests because that is integrated with the nginx-ingress-integrator charm, not directly to the Ranger charm.

@mertalpt mertalpt merged commit 62422eb into main Jun 13, 2025
21 checks passed
@mertalpt mertalpt deleted the lego-compatibility branch June 13, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants