fix: update ibm-vpc dependencies per breaking change in 0.28.0 #485
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
force-pushed
the
fix-ibm-vpc-version-required
branch
from
161520b to
4583105
Compare
Release of ibm-vpc 0.28.0 forces providing a known API version on VpcV1 __init__. API versions can be determined at https://github.com/IBM/vpc-python-sdk/releases/. Continue bump setup.cfg contraints in coordination with an ibm-vpc API version change to avoid unexpected integration test failures when subsequent releases of ibm-vpc are published.
|
cc: @uhryniuk as CPC ibm runners probably would have gotten broken by this too |
@blackboxsw Thanks for the heads up! 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release of ibm-vpc 0.28.0 forces providing a known API version on VpcV1 init. API versions can be determined at
https://github.com/IBM/vpc-python-sdk/releases/.
Continue bump setup.cfg contraints in coordination with an ibm-vpc API version change to avoid unexpected integration test failures when subsequent releases of ibm-vpc are published.
Description
Additional Context and Relevant Issues
Failures of jenkins IBM integration test runners started 7 days ago
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-ibm-generic/lastSuccessfulBuild/consoleText
upstream issue reported to make this version requirement more public version= now required for VpcV1 class instantiation IBM/vpc-python-sdk#89
Test Steps