Provide Oracle instances with a subnet id to use and provide metadata to instance launch. #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
To ease the process of reviewing your PR, do make sure to complete the following checklist before submitting a pull
request.
tox -e format
locally to automatically format my code before submittingtox
locally ensuring that it passes before submittingOtherwise, please leave the PR as a draft to indicate that it is still a work in progress.
Description
The following changes allow Oracle instances to be created on a specific subnet by providing the OCID for that subnet ahead of time. This is in contrast to the existing ways of finding the subnet by name or using related objects (vcn, network client, etc).
Additionally, this PR allows for users to provide a metadata dictionary directly to the instance launch. Previously, this was limited to providing the authorized ssh keys or user data to a default metadata dictionary. The default dictionary and provided dictionary are combined to ensure backwards compatibility.
Additional Context and Relevant Issues
Often in OCI scripts, the subnet OCID is previously known and being able to directly supply it would be advantageous. While providing metadata directly is required when using other services such as OKE, where metadata must be passed to instances based on cluster configuration.
Test Steps
N/A