-
Notifications
You must be signed in to change notification settings - Fork 34
feat(oracle): allow for specifiying config and key file from env vars #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oracle): allow for specifiying config and key file from env vars #465
Conversation
3d996a1
to
00f6f61
Compare
@mstpn ignore the first class/suite of tests in test_util.py ( |
00f6f61
to
0045378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can fix the pylint
errors everything else looks good to me.
Thanks for cleaning up the tests for readability.
84bf252
to
7942fbd
Compare
After linter errors are sorted then you're g2g |
7942fbd
to
ede4adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here @a-dubs.
PR Checklist
To ease the process of reviewing your PR, do make sure to complete the following checklist before submitting a pull
request.
tox -e format
locally to automatically format my code before submittingtox
locally ensuring that it passes before submittingOtherwise, please leave the PR as a draft to indicate that it is still a work in progress.
Proposed Commit Message
N/A
Description and Relevant Issues
This will allow for testing OCI on jenkins 🎉
Since the config file and the oci pem key file are stored in credentials bindings on jenkins, we need to be able to reference their paths using just environment variables, and more importantly, pycloudlib needs to be able to insert the key file path into the oci config at runtime using the key file path given to it via the new env var.
Additional Context
Test Steps
I added new unit tests for both the helper function itself and also to end-to-end test the OCI cloud constructor when environment variables are used. I generated html coverage report and ensured 100% coverage of newly added code.
Manual Testing
Ran the oracle example file using the following command and ensured via the logs that my new oci config was being read correctly:
Merge type