fix(oracle): fix subnet selection logic #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
force-pushed
the
oracle-fix-subnet-selection
branch
3 times, most recently
from
621d5f2 to
554739b
Compare
uhryniuk
approved these changes
Jan 30, 2025
TheRealFalcon
approved these changes
Feb 3, 2025
When a subnet is not associated with an availability domain (AD), we should not ignore the subnet just because it does not match our configured AD. This change fixes the subnet selection logic to first check if the subnet is associated with an AD before checking if it matches the configured AD. Before this change, the subnet selection logic was flawed and would say it was using a certain subnet, but due to this bad AD logic, it would actually not actually use the subnet it said it was using. New unit test file was added that provides 100% coverage of the get_subnet_id function!
a-dubs
force-pushed
the
oracle-fix-subnet-selection
branch
from
554739b to
fb9ba41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subnet is not associated with an availability domain (AD),
we should not ignore the subnet just because it does not match our
configured AD. This change fixes the subnet selection logic to first
check if the subnet is associated with an AD before checking if it
matches the configured AD.
Before this change, the subnet selection logic was flawed and would
say it was using a certain subnet, but due to this bad AD logic, it
would actually not actually use the subnet it said it was using.
New unit test file was added that provides 100% coverage of the
get_subnet_id function!