feat(ibm): improve ibm vpc baremetal behaviour #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
force-pushed
the
fix-ibm-vpc-baremetal
branch
2 times, most recently
from
ae2328b to
179790e
Compare
aciba90
requested changes
May 16, 2024
| """ | ||
| if self._instance["status"] == _Status.FAILED.value: | ||
| if any( | ||
| "capacity" in reason["code"] |
There was a problem hiding this comment.
Do we have a link pointing for docs covering this? If so, would you mind adding it for reference?
There was a problem hiding this comment.
I don't have any docs for this. I discovered this by manually launching and inspecting instance status via the API/SDK.
a-dubs
force-pushed
the
fix-ibm-vpc-baremetal
branch
2 times, most recently
from
da663a7 to
a129908
Compare
Previously, if baremetal instances could not be launched due to lack of capacity on the IBM Cloud, pycloudlib would fail to detect this and just assume that the instance booted correctly. Now, pycloudlib will return a capacity exception once this is detected, allowing for consumers of pycloudlib to properly implement retries for BM instances on IBM VPC.
a-dubs
force-pushed
the
fix-ibm-vpc-baremetal
branch
from
a129908 to
85db81a
Compare
aciba90
approved these changes
May 23, 2024
| # if self.b | ||
| self._wait_for_status( | ||
| _Status.RUNNING, | ||
| sleep_seconds=900, |
There was a problem hiding this comment.
This is good for now. But, the 900 should be configurable from a consumer POV, as it might be not flexible enough.
There was a problem hiding this comment.
Okay I'll look at adding this sometime soon. Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Description
Previously, if baremetal instances could not be launched due to
lack of capacity on the IBM Cloud, pycloudlib would fail to detect
this and just assume that the instance booted correctly.
Now, pycloudlib will return a capacity exception once this is
detected, allowing for consumers of pycloudlib to properly
implement retries for BM instances on IBM VPC.
Description of Testing:
This was tested both through an external program that leverages pycloudlib, and through a modified version of the ibm example script. The external program validated the use case of implementing retries for baremetal.