Skip to content

chore(python): update python rock #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2025
Merged

chore(python): update python rock #645

merged 3 commits into from
Oct 7, 2025

Conversation

@alesancor1
Copy link
Member

source repo has been renamed and updated

Ping the @canonical/rocks team.

Description

Update the python rock according to the latest changes in the repository

@alesancor1
chore(python): update python rock
1873a8b 
source repo has been renamed and updated
@alesancor1 alesancor1 marked this pull request as ready for review October 2, 2025 14:34
lczyk
lczyk approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

cjdcordeiro
cjdcordeiro requested changes Oct 3, 2025
View reviewed changes
zhijie-yang
zhijie-yang requested changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image trigger looks good to me. Just a few nitpicks on the EOLs.

We also have to override the EOLs in the documentation.yaml file since we are having the 3.13-25.04 image, which has a deviated "base" from the build-base in the rockcraft.yaml file.

@alesancor1
Copy link
Member Author

The overriden EOL was already there in documentation.yaml @zhijie-yang 👍

@zhijie-yang zhijie-yang merged commit 9802d1f into main Oct 7, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro requested changes

@zhijie-yang zhijie-yang zhijie-yang requested changes

@lczyk lczyk lczyk approved these changes

@ROCKsBot ROCKsBot Awaiting requested review from ROCKsBot ROCKsBot is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alesancor1 @cjdcordeiro @zhijie-yang @lczyk