Skip to content

Conversation

@sharder996
Copy link
Collaborator

@sharder996 sharder996 commented Oct 23, 2025

This PR implemented the design done by @vikorama which can is demonstrated in Figma.

The notable changes are the grouping of releases under a given OS as well as graphics for Debian and Fedora images.

See MULTI-1960 for info on the design.

Screenshot 2025-10-23 at 10 25 54 AM

Closes #4021


MULTI-2356

@sharder996 sharder996 requested review from jimporter and xmkg October 23, 2025 15:38
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.45%. Comparing base (525fa4c) to head (0499baf).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4474      +/-   ##
==========================================
+ Coverage   89.07%   89.45%   +0.38%     
==========================================
  Files         240      240              
  Lines       15263    13820    -1443     
==========================================
- Hits        13595    12363    -1232     
+ Misses       1668     1457     -211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sharder996 sharder996 requested a review from vikorama October 23, 2025 16:07
@vikorama
Copy link
Collaborator

vikorama commented Oct 24, 2025

@sharder996 Looking great! A couple of adjustments I'd do to the cards:

  1. The cards in one row are always the same size, but the rows can have different height if there's not enough content (hopefully with time we ensure all images are "advertised" in the same way). There shouldn't be so much white space, unless necessary for row alignment.
image
  1. The dropdown should be at the same position in the row

  2. The dropdown should match the dropdown style from the settings (chevron not filled, light-grey background F5F5F5 hex code).

  3. The outline of the cards should have higher contrast with the background. In our design system it's called high-contrast with the 707070 Hex code.

  4. [Bonus - not related to this issue specifically] Overall, in our Design system the buttons don't have border radius (the corners are not rounded). I don't know if it's an easy fix in Flutter, but would significantly increase consistency with the Design system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants