-
Notifications
You must be signed in to change notification settings - Fork 732
[submodules] Replace yaml-cpp submodule with vcpkg #4459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 238 238
Lines 15253 15253
=======================================
Hits 13572 13572
Misses 1681 1681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! CI is green, and I've verified locally that there aren't any extra places we need to update our build scripts.
@xmkg Actually... one question: do you have any thoughts about whether we should pin our |
Right now, the vcpkg's Line 2 in 2eb4538
This also applies to the dependency's whole ancestry, too. That's except for explicit version overrides, see: Lines 8 to 11 in 2eb4538
I'm okay with explicit pins too, but if our concerns are about reproducibility, "builtin-baseline" should suffice. Let me know what you think. |
MULTI-2343