Release/1.16 #4327
Merged
Release/1.16 #4327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) The previously generated gRPC server certificate's issuer could be different than the current one in certain circumstances, like a manual installation after a snap installation of Multipass. The patch fixes that by loading both the root and the subordinate cert for the gRPC server and verifying that the root certificate is the issuer. Also added some logs to the certificate regeneration logic. Fixes #4218 MULTI-2100
Changes the logic of where root certificates are stored on all platforms to always be in the same location. This avoids having the client and daemon looking in different locations. fixes #4246 MULTI-2104
chown is a platform-specific function which depends uid and gid. these values are not available in Windows, and the chown impl is by default returns -1. This causes filesystem operation failures in Windows hosts when sshfs mounts are used in guests. One example is as follows: ubuntu@foo:~/Downloads$ echo "test" > foo.txt -bash: foo.txt: Operation not permitted This operation fails because it first lands in handle_open, which eventually calls chown to change the file's owner, which is a failure by default in Windows. The patch fixes that by introducing a shim function, chown_shim which returns success when either uid or gid is set to no_id_info_available. MULTI-2155
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4327 +/- ##
==========================================
+ Coverage 89.31% 89.32% +0.01%
==========================================
Files 259 259
Lines 15709 15729 +20
==========================================
+ Hits 14030 14050 +20
Misses 1679 1679 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Remember to restore the branch on merge! It's necessary for version derivation in the candidate channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do this via a PR now, to get the CLA check.