Update ssh_client.cpp #4307
Open
Update ssh_client.cpp #4307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vedant Borkar <vedantborkar1234@gmail.com>
Signed-off-by: Vedant Borkar <vedantborkar1234@gmail.com>
Co-authored-by: Mădălin-Florin GOIAN <79133273+MadalinGOIAN@users.noreply.github.com> Signed-off-by: Vedant Borkar <vedantborkar1234@gmail.com>
Signed-off-by: Vedant Borkar <vedantborkar1234@gmail.com>
There was a problem hiding this comment.
Looks good to me but I think @sharder996 is the one that needs to approve
Signed-off-by: Vedant Borkar <vedantborkar1234@gmail.com>
Signed-off-by: Vedant Borkar <vedantborkar1234@gmail.com>
Signed-off-by: Vedant Borkar <vedantborkar1234@gmail.com>
|
@ricab @sharder996 Waiting for your review. |
ricab
reviewed
Oct 14, 2025
There was a problem hiding this comment.
Hi @vedant-z,
Looking better now, but we have our own logging facility. We're also working on this, so @tobe2098 is going to integrate with your changes, tweak a few things on top, and take care of tests and other things. Are you OK with that?
We'd need you to sign the CLA if you haven't done so yet.
|
@ricab Yeah sure. I don't have any issues. Signed the CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4227
The modified file contains one of the deprecated function
ssh_channel_get_exit_status. Replaced it withssh_channel_get_exit_state.@sharder996