-
Notifications
You must be signed in to change notification settings - Fork 736
[rust] init multipass cargo workspace & oxidize petname #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
levkropp
wants to merge
28
commits into
main
Choose a base branch
from
rust-oxidize-petname
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aef62cd to
9e97f97
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4299 +/- ##
==========================================
+ Coverage 89.28% 89.30% +0.02%
==========================================
Files 260 261 +1
Lines 17532 17636 +104
==========================================
+ Hits 15653 15750 +97
- Misses 1879 1886 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ba6110 to
3eb38a4
Compare
62934bd to
c2362e5
Compare
7e8db3f to
85c05d5
Compare
84d93aa to
2c1c524
Compare
63f1895 to
260c611
Compare
In order to avoid having a staticlib with duplicated dependencies for each oxidized module in multipass, the decision was made to have one crate that gets built/bridged via CXX, with each oxidized part of multipass in a subdirectory
8a41617 to
42c40c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Rust to Multipass by migrating the petname (name generation e.g.
hearty-kangaroo) functionality from C++ to Rust and integrates it into the build and runtime environments. This transition involves replacing the old C++ name generator with a new Rust implementation, updating the build system to compile and link the Rust static library, and adapting relevant CI and packaging scripts to support Rust. The changes also update C++ code to use the Rust FFI for name generation and remove legacy C++ petname code.Petname/name generation migration to Rust:
rustipass) and implemented petname in rust as a module, exposing FFI functions for name generation and tests.src/client/gui/ffi/dart_ffi.cpp,src/daemon/daemon.cpp) to use Rust FFI for petname generation instead of the old C++NameGenerator.include/multipass/name_generator.h,src/petname/make_name_generator.cpp).Build system and CI integration:
src/petname/CMakeLists.txt).github/workflows/dynamic-ci.yml,.github/workflows/windows-macos.yml).Packaging and environment updates:
BUILD.*.md,snap/snapcraft.yaml)Daemon configuration cleanup:
NameGeneratorfrom daemon configuration code (src/daemon/daemon_config.cpp,src/daemon/daemon_config.h).MULTI-2218