-
Notifications
You must be signed in to change notification settings - Fork 736
[tools/cli_tests] introduce Multipass CLI tests #4220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 238 238
Lines 15253 15253
=======================================
Hits 13572 13572
Misses 1681 1681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
01a72c1 to
7fd7696
Compare
957acff to
510af3f
Compare
fefae81 to
1fb8eda
Compare
089b48c to
1a0b98f
Compare
341365b to
b9a2c1a
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Sometimes, the VM is not ready to accept connections after a "multipass restart", causing subsequent checks to fail. This patch introduces a pre and post hook to multipass() which is triggered when the "restart" command is used. The pre() hook would grab the boot-id's of the VMs that passed to the restart, and post() would ensure that the multipass() won't return before the boot-id of each VM has changed, ensuring both VM connectivity and the reboot. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
83a25b3 to
4bdb7f3
Compare
pywinpty 3 freezes when pty_proc.pty.iseof() is called. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
|
@Sploder12, this is ready for another round of review in Windows. I've addressed Windows privilege and path-related issues and made a couple of resiliency measures in code. Let me know how it runs on your end :) |
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
7dfe840 to
29d2db2
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
c0317df to
dddf72f
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
|
Hi @sharder996, this should be ready for review in Mac, too. I've tested with my MBP '19 (Intel) with non-privileged user, the tests work as expected. Also, the Mac CI job now runs smoothly too. Please let me know if you encounter any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good on Windows! I marked resolved comments resolved, only some nitpicks remain. I have attached the full output again.
|
|
||
| # |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return of the super nitpick! There is an extra newline here
|
|
||
| # |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem
|
I'm still having trouble on macOS. I don't get queried a second for root authentication, but there still seems to be some trouble accessing the Multipass daemon. |
It is strange -- the same command line works just fine here: Are you running on Tahoe? Also could you re-run the tests with the following parameters added and paste the output here: Thanks! |
CLI tests aim to test the high-level, user-facing Multipass functionality
via the CLI commands. The tests are written in Python, and the suite uses
pytestas the test executor.See
README.mdfor more details.Signed-off-by: Mustafa Kemal Gilor mustafa.gilor@canonical.com