Skip to content

Conversation

@sharder996
Copy link
Collaborator

@sharder996 sharder996 commented Jul 8, 2025

MULTI-2065

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.33%. Comparing base (fa0f993) to head (5e8a068).
⚠️ Report is 459 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4217   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         259      259           
  Lines       15711    15711           
=======================================
  Hits        14035    14035           
  Misses       1676     1676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sharder996 sharder996 marked this pull request as ready for review July 9, 2025 18:23
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on an x86 machine, minimum version was 13 and multipass worked

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done Scott! I tested the resulting package on my Intel Mac and it worked smoothly. I have a tiny thing below, but pre-approving.

workflow_dispatch:
inputs:
host-my-apple:
description: "Run on HostMyApple MacOS 12 runners"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought they were 13 by now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the ARM Mac:

% ssh sharder996@192.30.132.184
(sharder996@192.30.132.184) Password:
Last login: Tue Jul  8 14:12:24 2025 from 204.112.26.160
sharder996@colegacy ~ % sw_vers
ProductName:	macOS
ProductVersion:	12.7.6
BuildVersion:	21H1320

Still on 12 I guess 🤷

MATRIX+='{"runs-on": "macos-13", "arch": "x86_64", "target": "13", "mono": "mono"},'
MATRIX+='{"runs-on": "macos-14", "arch": "arm64", "target": "14", "mono": ""},'
MATRIX+='{"runs-on": "macos-15", "arch": "arm64", "target": "15", "mono": ""}'
MATRIX+='{"runs-on": "macos-15", "arch": "arm64", "target": "15", "mono": ""},'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should drop this and save some electrons... but different PR anyway.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I had the same thought. Something to discuss in the future, then.

@sharder996 sharder996 added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit c6a6a15 Jul 11, 2025
24 checks passed
@sharder996 sharder996 deleted the macos-14 branch July 11, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants