-
Notifications
You must be signed in to change notification settings - Fork 736
[ci] deprecate HostMyApple runners #4217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4217 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 259 259
Lines 15711 15711
=======================================
Hits 14035 14035
Misses 1676 1676 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on an x86 machine, minimum version was 13 and multipass worked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, well done Scott! I tested the resulting package on my Intel Mac and it worked smoothly. I have a tiny thing below, but pre-approving.
| workflow_dispatch: | ||
| inputs: | ||
| host-my-apple: | ||
| description: "Run on HostMyApple MacOS 12 runners" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought they were 13 by now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the ARM Mac:
% ssh sharder996@192.30.132.184
(sharder996@192.30.132.184) Password:
Last login: Tue Jul 8 14:12:24 2025 from 204.112.26.160
sharder996@colegacy ~ % sw_vers
ProductName: macOS
ProductVersion: 12.7.6
BuildVersion: 21H1320
Still on 12 I guess 🤷
| MATRIX+='{"runs-on": "macos-13", "arch": "x86_64", "target": "13", "mono": "mono"},' | ||
| MATRIX+='{"runs-on": "macos-14", "arch": "arm64", "target": "14", "mono": ""},' | ||
| MATRIX+='{"runs-on": "macos-15", "arch": "arm64", "target": "15", "mono": ""}' | ||
| MATRIX+='{"runs-on": "macos-15", "arch": "arm64", "target": "15", "mono": ""},' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should drop this and save some electrons... but different PR anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I had the same thought. Something to discuss in the future, then.
MULTI-2065