Skip to content

Conversation

@levkropp
Copy link
Contributor

@levkropp levkropp commented Jul 2, 2025

This pull request introduces a new feature to persist the terminal font size setting across terminal tabs using the a session-level provider. The changes include modifying the font size logic in the terminal state, and updating the font size adjustment actions to save changes to the provider.

@levkropp levkropp requested review from Sploder12 and sharder996 July 2, 2025 14:26
Copy link
Collaborator

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to block on it, but it would be nice if the behaviour mirrored bash or zsh and it's terminal zoom didn't persist across application shutdown. i.e. reset back to default after quitting and restarting the Multipass GUI.

sharder996
sharder996 previously approved these changes Jul 3, 2025
@levkropp
Copy link
Contributor Author

levkropp commented Jul 4, 2025

I've created a new notifier and provider for terminal font size that resets when the GUI is closed. The previous implementation was using the guiSettingsProvider which saves its settings across sessions which was the reason for this behavior.

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.37%. Comparing base (f067fad) to head (f7f23c0).
⚠️ Report is 570 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4208   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files         259      259           
  Lines       15744    15744           
=======================================
  Hits        14071    14071           
  Misses       1673     1673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sharder996
sharder996 previously approved these changes Jul 7, 2025
Copy link
Collaborator

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @levkropp

@levkropp levkropp force-pushed the gui-terminal-sticky-zoom branch 6 times, most recently from bacb6f9 to 19c027f Compare July 14, 2025 19:05
@levkropp levkropp force-pushed the gui-terminal-sticky-zoom branch from 19c027f to 665b3d1 Compare July 23, 2025 16:02
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sharder996
Copy link
Collaborator

@levkropp needs another rebase to fix a linting issue that has since been merged in.

* use a provider that only persists for the session to remember font size between terminal tabs
@levkropp levkropp force-pushed the gui-terminal-sticky-zoom branch from 665b3d1 to f7f23c0 Compare July 23, 2025 18:40
@sharder996 sharder996 added this pull request to the merge queue Jul 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2025
@sharder996 sharder996 added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 69104d1 Jul 24, 2025
24 checks passed
@sharder996 sharder996 deleted the gui-terminal-sticky-zoom branch July 24, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants