-
Notifications
You must be signed in to change notification settings - Fork 736
[gui] remember terminal font size #4208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to block on it, but it would be nice if the behaviour mirrored bash or zsh and it's terminal zoom didn't persist across application shutdown. i.e. reset back to default after quitting and restarting the Multipass GUI.
|
I've created a new notifier and provider for terminal font size that resets when the GUI is closed. The previous implementation was using the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4208 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 259 259
Lines 15744 15744
=======================================
Hits 14071 14071
Misses 1673 1673 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, @levkropp
bacb6f9 to
19c027f
Compare
19c027f to
665b3d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@levkropp needs another rebase to fix a linting issue that has since been merged in. |
* use a provider that only persists for the session to remember font size between terminal tabs
665b3d1 to
f7f23c0
Compare
This pull request introduces a new feature to persist the terminal font size setting across terminal tabs using the a session-level provider. The changes include modifying the font size logic in the terminal state, and updating the font size adjustment actions to save changes to the provider.