[hyper-v] Move disabling automatic checkpoints to vm creation #4205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmkg
force-pushed
the
bugfix/hyperv-move-automatic-checkpoint-to-new-vms-only
branch
from
78200a5 to
c71ebcc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 259 259
Lines 15684 15684
=======================================
Hits 14008 14008
Misses 1676 1676 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currently, disabling automatic checkpoints causes issues when the VM is not in an appropriate state at the time the constructor is executed. This causes the daemon to crash since the command throws an exception. Fixes: #4204 Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
force-pushed
the
bugfix/hyperv-move-automatic-checkpoint-to-new-vms-only
branch
from
c71ebcc to
eab38fd
Compare
ricab
approved these changes
Jul 2, 2025
| inline static const std::vector<RunSpec> postfix_ctor_runs = {{"Set-VM"}, {"Get-VMCheckpoint"}}; | ||
| {"Set-VMMemory"}, | ||
| {"Set-VM"}}; | ||
| inline static const std::vector<RunSpec> postfix_ctor_runs = {}; |
There was a problem hiding this comment.
We should be able to remove this now, no?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ricab
added a commit
that referenced
this pull request
Jul 2, 2025
Currently, disabling automatic checkpoints causes issues when the VM is not in an appropriate state at the time the constructor is executed. This causes the daemon to crash since the command throws an exception. Fixes: #4204 MULTI-2061
ricab
added a commit
to ricab/multipass
that referenced
this pull request
Jul 5, 2025
…cal#4205) Currently, disabling automatic checkpoints causes issues when the VM is not in an appropriate state at the time the constructor is executed. This causes the daemon to crash since the command throws an exception. Fixes: canonical#4204 MULTI-2061
ricab
added a commit
to ricab/multipass
that referenced
this pull request
Jul 5, 2025
…cal#4205) Currently, disabling automatic checkpoints causes issues when the VM is not in an appropriate state at the time the constructor is executed. This causes the daemon to crash since the command throws an exception. Fixes: canonical#4204 MULTI-2061
ricab
added a commit
to ricab/multipass
that referenced
this pull request
Jul 5, 2025
…cal#4205) Currently, disabling automatic checkpoints causes issues when the VM is not in an appropriate state at the time the constructor is executed. This causes the daemon to crash since the command throws an exception. Fixes: canonical#4204 MULTI-2061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, disabling automatic checkpoints causes issues when the VM is not in an appropriate state at the time the constructor is executed. This causes the daemon to crash since the command throws an exception.
Fixes: #4204
MULTI-2061