[gui] update to flutter 3.32.5 #4181
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4181 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 259 259
Lines 15684 15684
=======================================
Hits 14008 14008
Misses 1676 1676 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # Copy the native assets provided by the build.dart from all packages. | ||
| set(NATIVE_ASSETS_DIR "${PROJECT_BUILD_DIR}native_assets/windows/") | ||
| if(EXISTS "${NATIVE_ASSETS_DIR}") | ||
| install(DIRECTORY "${NATIVE_ASSETS_DIR}" | ||
| DESTINATION "${INSTALL_BUNDLE_LIB_DIR}" | ||
| COMPONENT Runtime) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Not a review, but is this to workaround that flutter build issue on Windows?
There was a problem hiding this comment.
I don't believe so. I went through the upgrade process as described in Andrei's handover doc while trying to preserve as much of Andrei's original work as possible, but I never encountered that bug as described in #165200. I can replicate the behaviour as described there, but didn't encounter it while upgrading.
The code block you referenced originally came from here. I'm not 100% sure why Andrei added it, but my best guess is that depending on what dependencies one has in their Flutter project, dart can generate native_assets. I did not notice any of these assets being generated from our project so I modified the install to only conditionally include the directory. Otherwise, the build process fails due to the directory not existing.
I am still doing some final verification, but so far I have not noticed any change in the operation of the GUI.
|
@xmkg I will rerun linting commands, fix merge conflicts, and rebase once you've reviewed. |
sharder996
force-pushed
the
flutter-3.32
branch
2 times, most recently
from
9b982b5 to
836c18d
Compare
sharder996
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
5 participants
Mostly changes due to new linting rules in
dart format.Closes #3980
Closes #4095
Closes #4131
Closes #4132
Closes #4163
MULTI-1848