Skip to content

Conversation

@sharder996
Copy link
Collaborator

Work done by @network-charles in #4052


Fixes #3883

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.30%. Comparing base (7ca76da) to head (b6bec28).
⚠️ Report is 418 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4168      +/-   ##
==========================================
- Coverage   89.31%   89.30%   -0.01%     
==========================================
  Files         259      259              
  Lines       15684    15684              
==========================================
- Hits        14008    14007       -1     
- Misses       1676     1677       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@geoffreynyaga geoffreynyaga self-requested a review June 18, 2025 07:08
Copy link
Contributor

@geoffreynyaga geoffreynyaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@xmkg xmkg added this pull request to the merge queue Jun 19, 2025
@xmkg
Copy link
Member

xmkg commented Jun 19, 2025

The coverage regression makes no sense since:

a-) We already have a unit test for it
b-) This MR does not include any code changes

Queuing this one.

Merged via the queue into main with commit 47f57a0 Jun 19, 2025
22 of 23 checks passed
@xmkg xmkg deleted the docs/start-instance-instructions branch June 19, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add instructions on restarting instance in "https://canonical.com/multipass/docs/add-a-network-to-an-existing-instance"

4 participants