[no-merge] Testing runners #4066

ricab · 2025-04-29T17:55:34Z

No description provided.

Remove a ctest environment variable which was first introduced in #1768, but later removed in #1771. It inadvertently crept back into full with a release-branch merge: 30a86ef.

Do not include the VirtualBox backend on Linux builds by default (but continue allowing the option).

Fix white space errors introduced with the merger.

Remove carriage returns from Windows "licence.rtf".

Fix incomplete QEMU executable names (i.e. `qemu-system-` instead of `qemu-system-x86_64`), by defining HOST_ARCH for Linux too.

Merge full

(Breaks tests build.)

(Tests build still broken.)

(Fixes tests.)

Remove now-empty functions that used to check for alias, remote, and URL support. (Breaks tests build.)

Remove support-checking mocks for alias, remote, and URL. Adapt or remove any tests for such obsolete feature-locking behaviors. (Fixes tests.)

Remove obsolete unsupported alias/remote exceptions. Adapt code accordingly.

Remove unused capture and redundant namespace qualification.

Remove obsolete boolean indicating whether Multipass is "unlocked" when fetching an image.

Remove header for declarations common to proprietary platforms (macOS and Windows). Note that the compilation unit (platform_proprietary.cpp) remains, has it contains an implementation that is common to these two platforms.

Extract a remote accessor in UbuntuVMImageHost, for later reuse.

Add support for custom image filtering in the UbuntuVMImageHost and use it to filter snapcraft images.

Re-instate private visibility for fields of the UbuntuVMImageRemote. To that end, add a public method to check for image admission.

Remove cleanup step for a job that used to run in custom infrastructure but which runs on GitHub runners nowadays (we don't need to clean those).

Improve job and step naming to distinguish them from other types of cleanup that are involved in our mac workflows.

Directly checkout the ref/sha that triggered the workflow directly also on the WindowsMacOS workflow. We no longer need to create a special branch to merge public into private.

Remove custom action to checkout submodules. The motivating limitations no longer appear to hold.

Correct comment to reflect actual reason for full fetch depth at checkout.

It's now checked out in a standard manner. Reorder steps accordingly.

The standard checkout mechanism that is now employed automatically cleans up after itself. However, the custom cleanup would run beforehand and cause the automatic cleanup to fail.

Jobs started running out of disk space.

Addresses review request.

Merge CI

Hardcode the number of characters to abbreviate the hash with to 8, when deriving the version.

[cmake] Abbreviate hash with 8 chars for version

codecov · 2025-04-29T18:37:30Z

Codecov Report

❌ Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.46%. Comparing base (3c489ca) to head (e7341d8).

Files with missing lines	Patch %	Lines
src/daemon/daemon_config.cpp	8.33%	11 Missing ⚠️
src/daemon/ubuntu_image_host.cpp	90.62%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           merger    #4066      +/-   ##
==========================================
- Coverage   89.52%   89.46%   -0.06%     
==========================================
  Files         260      258       -2     
  Lines       14744    14717      -27     
==========================================
- Hits        13199    13166      -33     
- Misses       1545     1551       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ricab added 30 commits April 23, 2025 00:51

Merge branch 'full' into main

29023d8

[ci] Continue triggering workflows as in main

388afba

[ci] Remove bogus environment line from full

a7c5d16

Remove a ctest environment variable which was first introduced in #1768, but later removed in #1771. It inadvertently crept back into full with a release-branch merge: 30a86ef.

[cmake] Remove VirtualBox backend from Linux

d873eeb

Do not include the VirtualBox backend on Linux builds by default (but continue allowing the option).

[various] Revert to main in a few small respects

e65f122

[format] Fix white space errors

52422dd

Fix white space errors introduced with the merger.

[format] Remove carriage returns from licence file

da1accb

Remove carriage returns from Windows "licence.rtf".

[format] Fix formatting on new files

508bdbd

[linux] Fix HOST_ARCH define on Linux build

ea7c063

Fix incomplete QEMU executable names (i.e. `qemu-system-` instead of `qemu-system-x86_64`), by defining HOST_ARCH for Linux too.

Merge pull request #711 from canonical/merge-full

3c4d6ac

Merge full

[platform] Unlock blueprint URL overriding

046d4c5

(Breaks tests build.)

[tests] Remove obsolete tests for blueprints URL

a36ff9f

(Tests build still broken.)

[tests] Adapt remaining tests to removed function

9a9f0ec

(Fixes tests.)

[config] Replace UTF-16 unfriendly qgetenv

5858823

[config] Extract constant for environment variable

a36905f

[platform] Unlock alias, remote, and URL support

88cb538

[platform] Remove unlock code

e5de51a

[platform] Remove feature-lock-checking functions

17ca76d

Remove now-empty functions that used to check for alias, remote, and URL support. (Breaks tests build.)

[tests] Adapt or remove locked-feature tests

aa0d758

Remove support-checking mocks for alias, remote, and URL. Adapt or remove any tests for such obsolete feature-locking behaviors. (Fixes tests.)

[except] Remove obsolete exceptions

63bc2f0

Remove obsolete unsupported alias/remote exceptions. Adapt code accordingly.

[image-hosts] Remove a couple of leftovers

c91c96f

Remove unused capture and redundant namespace qualification.

[vault] Remove obsolete unlock parameter

51cc98a

Remove obsolete boolean indicating whether Multipass is "unlocked" when fetching an image.

[platform] Remove now useless platform_shared.h

2d6970b

[platform] Remove platform_proprietary.h

c986a3a

Remove header for declarations common to proprietary platforms (macOS and Windows). Note that the compilation unit (platform_proprietary.cpp) remains, has it contains an implementation that is common to these two platforms.

[image-hosts] Extract a remote accessor

ed79e29

Extract a remote accessor in UbuntuVMImageHost, for later reuse.

[image-hosts] Relocate snapcraft image filtering

edf141f

Add support for custom image filtering in the UbuntuVMImageHost and use it to filter snapcraft images.

[image-hosts] Drop obsolete include

6c7eac0

[config] Improve snapcraft image filtering

8ab95bc

[image-hosts] Revert attribute visibility

83d0031

Re-instate private visibility for fields of the UbuntuVMImageRemote. To that end, add a public method to check for image admission.

[image-hosts] Constrain method visibility

de7d5e7

ricab and others added 25 commits April 23, 2025 01:22

[ci] Stop updating mac checks on public

9242e9c

[ci] Drop a couple more unused outputs

3b2d18e

[ci] Update job and step names

102740b

[ci] Restrict snap upload to public repo

373b9b0

[ci] Drop obsolete cleanup step

65dc6f5

Remove cleanup step for a job that used to run in custom infrastructure but which runs on GitHub runners nowadays (we don't need to clean those).

[ci] Improve job and step naming

202422b

Improve job and step naming to distinguish them from other types of cleanup that are involved in our mac workflows.

[ci] Use a standard checkout in mac/win workflows

9b4538b

Directly checkout the ref/sha that triggered the workflow directly also on the WindowsMacOS workflow. We no longer need to create a special branch to merge public into private.

[ci] Drop custom checkout action

4c6e49b

Remove custom action to checkout submodules. The motivating limitations no longer appear to hold.

[ci] Correct comment

170cb12

Correct comment to reflect actual reason for full fetch depth at checkout.

[ci] Remove artifact download for repository

35285f3

It's now checked out in a standard manner. Reorder steps accordingly.

[ci] Remove obsolete HEAD_REF environment variable

a038cd5

[ci] Remove obsolete cleanup scheduling

bf90d2b

The standard checkout mechanism that is now employed automatically cleans up after itself. However, the custom cleanup would run beforehand and cause the automatic cleanup to fail.

[ci] Use main instead of full for cache-key

87f510a

[ci] Improve var naming

9901c47

[ci] Split long YAML lines

99f9a1c

[ci] Remove obsolete environment variables

704fa51

[ci] Remove obsolete output variable

c7fcb1e

[ci] Move variable to step's environment

b5a1279

[ci] Improve job name

51f5339

[ci] Free disk space on Linux builds

adb9b90

Jobs started running out of disk space.

[ci] Set safer shell options when deriving matrix

50a988b

Addresses review request.

Merge pull request #738 from canonical/merge-ci

73cf900

Merge CI

[cmake] Abbreviate hash with 8 chars for version

2a061fc

Hardcode the number of characters to abbreviate the hash with to 8, when deriving the version.

Merge pull request #751 from canonical/limit-version-size

5d0e5fa

[cmake] Abbreviate hash with 8 chars for version

Testing runners

e7341d8

ricab added the no-merge label Apr 29, 2025

ricab force-pushed the merger branch 2 times, most recently from c18cac3 to 2f30447 Compare May 5, 2025 15:19

ricab closed this May 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[no-merge] Testing runners #4066

[no-merge] Testing runners #4066

Uh oh!

ricab commented Apr 29, 2025

Uh oh!

codecov bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

[no-merge] Testing runners #4066

[no-merge] Testing runners #4066

Uh oh!

Conversation

ricab commented Apr 29, 2025

Uh oh!

codecov bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Apr 29, 2025 •

edited

Loading