Merge ci #4059
Closed
Merge ci #4059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same triggers across platforms, in preparation for move to public repo.
I know of no reason why we wouldn't. This will simplify extracting the jobs into a separate workflow.
Extract Lint to a separate workflow, on whose success all builds depend on, except if triggered on a PR (so that we have the benefit of other results regardless or linting problems).
Improve name, id, and comments on the step that prioritizes gnu-tar over the system one on macOS.
This is currently broken and will need rewriting, hopefully in a simplified form.
Remove cleanup step for a job that used to run in custom infrastructure but which runs on GitHub runners nowadays (we don't need to clean those).
Improve job and step naming to distinguish them from other types of cleanup that are involved in our mac workflows.
Directly checkout the ref/sha that triggered the workflow directly also on the WindowsMacOS workflow. We no longer need to create a special branch to merge public into private.
Remove custom action to checkout submodules. The motivating limitations no longer appear to hold.
Correct comment to reflect actual reason for full fetch depth at checkout.
It's now checked out in a standard manner. Reorder steps accordingly.
The standard checkout mechanism that is now employed automatically cleans up after itself. However, the custom cleanup would run beforehand and cause the automatic cleanup to fail.
Jobs started running out of disk space.
Addresses review request.
|
We'll merge this on the other side, where it's already undergone reviews. Just want to exercise it here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## merger #4059 +/- ##
=========================================
Coverage ? 89.46%
=========================================
Files ? 258
Lines ? 14717
Branches ? 0
=========================================
Hits ? 13166
Misses ? 1551
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hitting a 32 char limit on the version... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.