-
Notifications
You must be signed in to change notification settings - Fork 737
lxd libvirt deprecation warning docs #4033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4033 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 260 260
Lines 14738 14738
=======================================
Hits 13167 13167
Misses 1571 1571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, although I'm sure a little painful to add the note in multiple places. If there is any expectation that this change might need to be made again then you/we could look into ways of reusing and/or consolidating the information, but I don't think that's an issue here.
My only suggestion might be to add a prominent note at the top of the explanations > driver page, to make it more salient at a glance to the user:
```{warning}
Support for libvirt and LXD will be deprecated and removed in a future release.
```
I didn't find any instance of references to "LXD" and "libvirt" that you missed.
d55b591 to
82a8f98
Compare
37b7581 to
2b0c992
Compare
MULTI-1888
MULTI-1893
This PR is about adding the driver warning messages to all the lxd and libvirt related documentation pages.