Skip to content

Conversation

@georgeliao
Copy link
Contributor

@georgeliao georgeliao commented Apr 8, 2025

MULTI-1888
MULTI-1893

This PR is about adding the driver warning messages to all the lxd and libvirt related documentation pages.

@georgeliao georgeliao changed the title Lxd libvirt deprecation warning docs lxd libvirt deprecation warning docs Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (7cb6b2b) to head (5407baa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4033   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         260      260           
  Lines       14738    14738           
=======================================
  Hits        13167    13167           
  Misses       1571     1571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@edibotopic edibotopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, although I'm sure a little painful to add the note in multiple places. If there is any expectation that this change might need to be made again then you/we could look into ways of reusing and/or consolidating the information, but I don't think that's an issue here.

My only suggestion might be to add a prominent note at the top of the explanations > driver page, to make it more salient at a glance to the user:

```{warning}
Support for libvirt and LXD will be deprecated and removed in a future release.
```

I didn't find any instance of references to "LXD" and "libvirt" that you missed.

@sharder996 sharder996 force-pushed the lxd_libvirt_deprecation_warning_docs branch from 37b7581 to 2b0c992 Compare April 10, 2025 19:17
@sharder996 sharder996 marked this pull request as draft April 10, 2025 19:20
@sharder996 sharder996 marked this pull request as ready for review April 10, 2025 19:20
@ricab ricab merged commit 1af17e5 into main Apr 11, 2025
3 checks passed
@ricab ricab deleted the lxd_libvirt_deprecation_warning_docs branch April 11, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants