Skip to content

[gh/wf/linux.yml] allow workflow cancellation #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025
Merged

[gh/wf/linux.yml] allow workflow cancellation #4030

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2576af9
[gh/wf/linux.yml] set concurrency.cancel-in-progress to true
xmkg Apr 7, 2025
d8e4a20
[gh/wf/linux.yml] set group name based on gh doc recommendations
xmkg Apr 7, 2025
566db19
[gh/wf/linux.yml] sprinkle some job-level !cancelled() checks
xmkg Apr 18, 2025
614b3bd
[gh/wf/linux.yml] fix alignment and readability of condition
xmkg Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ on:
types: [checks_requested]

concurrency:
group: ${{ github.workflow }}-${{ github.event.number && format('pr{0}', github.event.number) || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'merge_group' }}
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
Lint:
runs-on: ubuntu-latest

if: ${{ contains('pull_request merge_group', github.event_name) }}
if: ${{ !cancelled() && contains('pull_request merge_group', github.event_name) }}

steps:
- name: Check out code
Expand Down Expand Up @@ -68,13 +68,16 @@ jobs:

# Allow skipped Lint
# Let Lint fail on pull requests
if: |
${{
success()
|| needs.Lint.result == 'skipped'
|| ( needs.Lint.result == 'failure'
&& github.event_name == 'pull_request' )
}}
if: ${{ !cancelled() &&
(
success() ||
needs.Lint.result == 'skipped' ||
(
needs.Lint.result == 'failure' &&
github.event_name == 'pull_request'
)
)
}}
Comment on lines +71 to +80
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of line splitting now, but ok...


outputs:
label: ${{ steps.build-params.outputs.label }}
Expand Down Expand Up @@ -309,9 +312,7 @@ jobs:
Publish-Snap:
needs: BuildAndTest
# Need to explicitly continue on Lint getting skipped.
if: ${{
!failure()
&& !cancelled()
if: ${{ !cancelled() && success()
&& needs.BuildAndTest.outputs.channel != ''
&& (github.event_name == 'push'
|| github.event_name == 'merge_group'
Expand Down Expand Up @@ -344,9 +345,7 @@ jobs:

# Only dispatch if we have access to secrets.
# Need to explicitly continue on Lint getting skipped.
if: ${{
!failure()
&& !cancelled()
if: ${{ !cancelled() && success()
&& (github.event_name == 'push'
|| github.event_name == 'merge_group'
|| github.event.pull_request.head.repo.full_name == github.repository)
Expand Down
Loading