Move openssl from binary installation to vcpkg #4023
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is same as the standard build recipe, the purpose it to convert the dynamic linkage to static. As a result, we can avoid the windows openssl_applink.c problem.
georgeliao
force-pushed
the
move_openssl_to_vcpkg
branch
from
afcff52 to
ebda7f8
Compare
georgeliao
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4023 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 260 260
Lines 14738 14738
=======================================
Hits 13167 13167
Misses 1571 1571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
https://warthogs.atlassian.net/browse/MULTI-1920
Things are not finished
close #3889