Skip to content

Conversation

@Sploder12
Copy link
Contributor

This PR removes lxd from the list of drivers in the GUI. If a user has lxd they will still be on lxd, however, once they switch to a different driver lxd will no-longer be selectable.

MULTI-1894

@Sploder12 Sploder12 force-pushed the gui-remove-libvirt-option branch from 7a4efdd to e69743f Compare March 28, 2025 16:58
@Sploder12 Sploder12 force-pushed the gui-remove-lxd-option branch from 3f1e789 to 97a4791 Compare March 28, 2025 16:58
xmkg
xmkg previously approved these changes Mar 28, 2025
@Sploder12 Sploder12 force-pushed the gui-remove-libvirt-option branch from e69743f to e3a69b1 Compare March 31, 2025 16:25
@Sploder12 Sploder12 force-pushed the gui-remove-lxd-option branch from 97a4791 to a8f04f6 Compare March 31, 2025 16:27
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (20b3f75) to head (3ae4004).
Report is 3406 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4019   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         260      260           
  Lines       14735    14735           
=======================================
  Hits        13164    13164           
  Misses       1571     1571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sploder12 Sploder12 force-pushed the gui-remove-libvirt-option branch from e3a69b1 to a7fd894 Compare April 2, 2025 16:56
@Sploder12 Sploder12 force-pushed the gui-remove-lxd-option branch 2 times, most recently from 4f97cda to 4b987e7 Compare April 2, 2025 17:01
@Sploder12 Sploder12 force-pushed the gui-remove-libvirt-option branch from a7fd894 to 20b3f75 Compare April 2, 2025 17:03
@Sploder12 Sploder12 force-pushed the gui-remove-lxd-option branch from 4b987e7 to 3ae4004 Compare April 2, 2025 17:05
andrei-toterman
andrei-toterman previously approved these changes Apr 2, 2025
Copy link
Contributor

@andrei-toterman andrei-toterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from gui-remove-libvirt-option to main April 2, 2025 22:58
@Sploder12 Sploder12 dismissed stale reviews from andrei-toterman and xmkg April 2, 2025 22:58

The base branch was changed.

@xmkg xmkg added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 883d45a Apr 3, 2025
16 checks passed
@xmkg xmkg deleted the gui-remove-lxd-option branch April 3, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants