Remove libvirt driver from GUI

[Sploder12]

This PR removes libvirt from the list of drivers in the GUI. If a user has libvirt they will still be on libvirt, however, once they switch to a different driver libvirt will no-longer be selectable.

MULTI-1889

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (5385fac) to head (20b3f75).
Report is 3408 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4018   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         260      260           
  Lines       14735    14735           
=======================================
  Hits        13164    13164           
  Misses       1571     1571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[levkropp]

Just tested with

• sudo snap install multipass
• setting the driver to libvirt in the gui
• confirming it can launch instances after installing libvirt and connecting multipass to libvirt with snap connect multipass:libvirt

Then I installed this PR with sudo snap refresh multipass --channel edge/pr4018 and was able to select a different backend in the GUI and could not return to the libvirt backend as expected

[levkropp]

So this change works for not showing libvirt as one of the drivers in the settings menu after switching away from it, but it does break being able to launch instances with libvirt after snap refresh installs this version. I'm not sure if this was happening when it was a provider as well

[Sploder12]

So this change works for not showing libvirt as one of the drivers in the settings menu after switching away from it, but it does break being able to launch instances with libvirt after snap refresh installs this version. I'm not sure if this was happening when it was a provider as well

I was able to recreate on the CLI as well, the full error ends in Could not open '/home/<user>/.local/share/multipassd/vault/instances/<instance>/<image>.img': Permission denied
This appears to be related to permissions. 😭

[ricab]

Hey @Sploder12, @levkropp, libvirt is very restrictive by default and a locally built Multipass daemon usually fails to launch VMs with "Permission denied" errors (that's regardless of the new permissions). I am not aware of that affecting the snap, so there is probably something else going on in here, but I wanted to make sure you guys don't confuse the two problems.

The permissions error we've always had on local builds can be overcome with something like:

1. sudoedit /etc/libvirt/qemu.conf
2. uncomment user = "root" line
3. close the editor
4. systemctl restart libvirtd

[Sploder12]

Thanks @ricab! That fixed it for me, I almost went on a wild goose chase!

[ricab]

Glad to be of service 🙂

[levkropp]

Can confirm that this fixed it on my end as well. Thank you @ricab !

[andrei-toterman]

Yup, all good 😄