-
Notifications
You must be signed in to change notification settings - Fork 736
az gui #3979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
az gui #3979
Conversation
24c52c5 to
79a74ad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## availability-zones #3979 +/- ##
======================================================
+ Coverage 89.10% 89.24% +0.14%
======================================================
Files 267 267
Lines 15160 15177 +17
======================================================
+ Hits 13508 13545 +37
+ Misses 1652 1632 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
81f1458 to
a6219c6
Compare
c5159fa to
68ada27
Compare
63d9e3b to
3651967
Compare
3dd506a to
6cede9b
Compare
51b2112 to
3b065cc
Compare
3b065cc to
e55f30d
Compare
11efe3b to
d619572
Compare
d619572 to
b86caf2
Compare
|
Still haven't tested the package as I'm getting an error, but one change we definitely need to do is to remove Pseudo everywhere. This was the feedback from the Roadmap team-only. |
|
Thank you @levkropp, a few things to look into:
|
TLDR: Here is what it looks like now, with the Figma design for reference. Please let me know what you think!
Unfortunately, we cannot set a font weight of 550 to the best of my knowledge. If we really want, we could create/add a new font where one of the font values w100 w200 etc corresponds to a version of the font at 550 weight Hi @vikorama , regarding your latest comments:
I do not have access to the documentation Figma you have linked. I have requested access. Do you mean something like the following? This is called a
To the best of my knowledge, Flutter only supports specific font weights: w100, w200, w300, w400, w500, w600, w700, w800, w900. There is no w550. For a weight between w500 and w600, the closest valid options is FontWeight.w500 or FontWeight.w600. It's currently set to 600, but I can make it 500 if you prefer
I am unable to reproduce this on Kubuntu 24.04. The switcher changes after a short delay for me after one click. There is a chance that this is also related to the incomplete implementation of availability/unavailiabilty in the branch, otherwise this may be a MacOS specific bug.
The font size for zone names is set to 16px https://api.flutter.dev/flutter/painting/TextStyle/fontSize.html
The subtitle is using the default font. There have been no changes made to kerning (letter spacing). I have updated it to now also be 16px with a line height of 24px
👍
👍
I agree that this should be in another PR |
affecab to
e1b367e
Compare
|
@levkropp Thank you for looking into all this! The look and the cursor are great!
If you agree, could you please make these minor adjustments? 🙏
Please see here for more details
|
bf18f23 to
c2a338e
Compare






Implement availability zones support in GUI
Add ZONE column to VM instances table
Add zone controls in bulk actions and filters
Add zone selection to instance configuration
Add Launch & Configure Next functionality