-
Couldn't load subscription status.
- Fork 736
[ci/BuildAndTest]: upload test coredump to artifacts on crash #3958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
511324e to
4b4df39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3958 +/- ##
=======================================
Coverage 89.11% 89.12%
=======================================
Files 255 255
Lines 14603 14603
=======================================
+ Hits 13014 13015 +1
+ Misses 1589 1588 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f2a42ec to
1836691
Compare
|
I've tested the crash dump capture and upload steps with a mock step (which has been removed now), and it seems to work properly. An example set of artifacts uploaded from the mock crash can be found here I've tried to retry the pipeline an unhealthy number of times but could not trigger the real crash, but I think the code will work for the real thing as the mock is pretty close to the real thing (observable behavior-wise). |
1836691 to
941ecaa
Compare
The BuıldAndTest(Debug) step crashes intermittenly without any significant clue for us to pursue. The crash does not happen in the local environment so the best next thing is to grab the core dump & crashed executable and upload them to artifacts so we can investigate them. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
941ecaa to
3273a11
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
4df339e to
67dfb16
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
|
We discussed this out-of-band with @ricab, and he said that he's OK with the concept, so this PR needs some eyes to confirm that I haven't missed anything obvious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks like there is a minor issue where an if isn't being evaluated as it should, but nothing major!
Somewhat unrelated but for separate future task/PR(s): It'd be cool to have something similar for Windows and MacOS as well. I know Apple Clang tends to crash so retrieving that would be nice to have too.
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
That's a good idea. Let's use this patch as a pilot program, land it, and see how well it works. Then, we can convert it to a dedicated action that can be reused in different workflows. Maybe we can even register a coredump handler just like apport to have minimal intrusion on the jobs and still be able to capture the stuff we need to troubleshoot. |
The BuıldAndTest(Debug) step crashes intermittently without any significant clue for us to pursue. The crash does not happen in the local environment so the best next thing is to grab the core dump & crashed executable and upload them to artifacts so we can investigate them.
MULTI-1845