Skip to content

Conversation

@xmkg
Copy link
Member

@xmkg xmkg commented Feb 26, 2025

The BuıldAndTest(Debug) step crashes intermittently without any significant clue for us to pursue. The crash does not happen in the local environment so the best next thing is to grab the core dump & crashed executable and upload them to artifacts so we can investigate them.

MULTI-1845

@xmkg xmkg force-pushed the enhancement/ci-upload-test-coredump-on-crash branch from 511324e to 4b4df39 Compare February 26, 2025 09:17
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (1954ca0) to head (26eb607).
Report is 3479 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3958   +/-   ##
=======================================
  Coverage   89.11%   89.12%           
=======================================
  Files         255      255           
  Lines       14603    14603           
=======================================
+ Hits        13014    13015    +1     
+ Misses       1589     1588    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xmkg xmkg force-pushed the enhancement/ci-upload-test-coredump-on-crash branch 19 times, most recently from f2a42ec to 1836691 Compare February 26, 2025 18:42
@xmkg xmkg marked this pull request as ready for review February 27, 2025 10:03
@xmkg
Copy link
Member Author

xmkg commented Feb 27, 2025

I've tested the crash dump capture and upload steps with a mock step (which has been removed now), and it seems to work properly. An example set of artifacts uploaded from the mock crash can be found here

I've tried to retry the pipeline an unhealthy number of times but could not trigger the real crash, but I think the code will work for the real thing as the mock is pretty close to the real thing (observable behavior-wise).

@xmkg xmkg force-pushed the enhancement/ci-upload-test-coredump-on-crash branch from 1836691 to 941ecaa Compare February 28, 2025 08:57
The BuıldAndTest(Debug) step crashes intermittenly without any significant
clue for us to pursue. The crash does not happen in the local environment
so the best next thing is to grab the core dump & crashed executable and
upload them to artifacts so we can investigate them.

Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
@xmkg xmkg force-pushed the enhancement/ci-upload-test-coredump-on-crash branch from 941ecaa to 3273a11 Compare February 28, 2025 09:11
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
@xmkg xmkg force-pushed the enhancement/ci-upload-test-coredump-on-crash branch from 4df339e to 67dfb16 Compare February 28, 2025 09:48
xmkg added 2 commits February 28, 2025 13:03
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
@xmkg xmkg requested review from Sploder12 and ricab and removed request for ricab February 28, 2025 13:44
@xmkg
Copy link
Member Author

xmkg commented Feb 28, 2025

We discussed this out-of-band with @ricab, and he said that he's OK with the concept, so this PR needs some eyes to confirm that I haven't missed anything obvious.

Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks like there is a minor issue where an if isn't being evaluated as it should, but nothing major!

Somewhat unrelated but for separate future task/PR(s): It'd be cool to have something similar for Windows and MacOS as well. I know Apple Clang tends to crash so retrieving that would be nice to have too.

Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
@xmkg
Copy link
Member Author

xmkg commented Feb 28, 2025

Somewhat unrelated but for separate future task/PR(s): It'd be cool to have something similar for Windows and MacOS as well. I know Apple Clang tends to crash so retrieving that would be nice to have too.

That's a good idea. Let's use this patch as a pilot program, land it, and see how well it works. Then, we can convert it to a dedicated action that can be reused in different workflows. Maybe we can even register a coredump handler just like apport to have minimal intrusion on the jobs and still be able to capture the stuff we need to troubleshoot.

@xmkg xmkg enabled auto-merge February 28, 2025 21:00
@xmkg xmkg added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit c991327 Mar 1, 2025
16 checks passed
@xmkg xmkg deleted the enhancement/ci-upload-test-coredump-on-crash branch March 1, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants