Skip to content

Conversation

@giuliazanchi
Copy link
Contributor

@giuliazanchi giuliazanchi commented Feb 19, 2025

I've removed (commented out) all image links and placed the images in a separate folder (docs/images).

NOTE: To build the docs locally, go in the docs folder and run the command make run. To see the available documentation checks and targets, just run make.

You can view a preview of the updated docs on RTD here: https://canonical-multipass--3942.com.readthedocs.build/en/3942/

@giuliazanchi giuliazanchi marked this pull request as draft February 19, 2025 09:48
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (5b4d884) to head (f2921b4).
Report is 3468 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3942   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         255      255           
  Lines       14603    14603           
=======================================
  Hits        13014    13014           
  Misses       1589     1589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giuliazanchi giuliazanchi marked this pull request as ready for review February 19, 2025 11:12
@giuliazanchi
Copy link
Contributor Author

Thanks for looking at this, @xmkg , perhaps you can help me figure out why those checks are failing?

Copy link
Member

@xmkg xmkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for a small apostrophe I've noticed in the docs. All images that are supposed to be seen are visible and relevant to the context. Commented-out ones are not visible, as they should be.

@xmkg
Copy link
Member

xmkg commented Feb 21, 2025

Hi @giuliazanchi, can you rebase this branch to main?

@xmkg xmkg enabled auto-merge February 21, 2025 08:44
@xmkg xmkg added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit f5c1102 Feb 21, 2025
16 checks passed
@xmkg xmkg deleted the move-images-to-github branch February 21, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants