Skip to content

Conversation

@giuliazanchi
Copy link
Contributor

  • Changed MyST syntax to render tabs
  • Improved labels in the navigation tree
  • Fixed two broken image links (asset manager)
  • Fixed order of pages in the navigation tree (now it's the same as in https://canonical.com/multipass/docs)
  • Updated conf.py to display the "Give feedback" button on all pages

NOTE: To build the docs locally, go in the /docs/ folder and run the command make run.

@giuliazanchi
Copy link
Contributor Author

giuliazanchi commented Feb 18, 2025

Hi @levkropp , I've rebased my commits and put everything on a branch of the main repo. The checks should pass now. Please let me know! Thank you
(The previous PR which I've closed was #3936)

EDIT: The docs build correctly, you can see them here: https://canonical-multipass--3940.com.readthedocs.build/en/3940/

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (2424799) to head (a25d7f2).
Report is 3479 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3940   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         255      255           
  Lines       14603    14603           
=======================================
  Hits        13013    13013           
  Misses       1590     1590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All of the fixes appear to be here and it builds and runs on my machine!

@levkropp levkropp added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit ec295dc Feb 19, 2025
16 checks passed
@levkropp levkropp deleted the small-fixes-to-docs-structure branch February 19, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants