Skip to content

Conversation

@andrei-toterman
Copy link
Contributor

@andrei-toterman andrei-toterman commented Feb 7, 2025

This PR adds the zones CLI command, for retrieving zones and their status.
It also adds AZ information to the list and info commands.
There is support for all the expected --format options.

There is also a change to the base Command class, in order to allow it to receive gRPC callbacks with const parameters.

MULTI-1871

@andrei-toterman andrei-toterman force-pushed the az-info-retrieval branch 3 times, most recently from a8dfbc5 to 4f5405a Compare February 7, 2025 23:46
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

❌ Patch coverage is 98.19820% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.36%. Comparing base (a9be08a) to head (c5b14fe).
⚠️ Report is 6 commits behind head on availability-zones.

Files with missing lines Patch % Lines
src/client/cli/cmd/zones.cpp 96.42% 1 Missing ⚠️
src/client/cli/formatter/csv_formatter.cpp 94.44% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           availability-zones    #3925      +/-   ##
======================================================
+ Coverage               89.30%   89.36%   +0.05%     
======================================================
  Files                     264      265       +1     
  Lines                   14953    15050      +97     
======================================================
+ Hits                    13354    13449      +95     
- Misses                   1599     1601       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@xmkg xmkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricab ricab requested review from levkropp and removed request for georgeliao April 4, 2025 15:45
@andrei-toterman andrei-toterman force-pushed the az-integration branch 2 times, most recently from 0f1e320 to 24dac77 Compare April 8, 2025 14:53
@andrei-toterman andrei-toterman force-pushed the az-info-retrieval branch 2 times, most recently from e859b3f to 848b4c3 Compare April 9, 2025 10:41
Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed a change to test_client_cli that adds coverage for zones.cpp

Processing file src/client/cli/cmd/zones.cpp
  lines=31 hit=30 functions=8 hit=7

@levkropp levkropp force-pushed the az-info-retrieval branch from 989f543 to 382dfca Compare May 12, 2025 13:19
Base automatically changed from az-integration to availability-zones July 10, 2025 17:57
@ricab
Copy link
Collaborator

ricab commented Jul 10, 2025

@levkropp this can now be merged, right?

@levkropp
Copy link
Contributor

@ricab still waiting for your review on #3926 then yes, everything except the GUI is all ready! 😄

@ricab
Copy link
Collaborator

ricab commented Jul 10, 2025

I just got back to #3926, then I noticed this. Do you think in this case we should merge that one into this first? Normally we merge in sequence.

@levkropp levkropp force-pushed the az-info-retrieval branch from 8709537 to c5b14fe Compare July 10, 2025 19:29
@levkropp levkropp merged commit 3fde24d into availability-zones Aug 18, 2025
19 checks passed
@levkropp levkropp deleted the az-info-retrieval branch August 18, 2025 16:33
Sploder12 pushed a commit that referenced this pull request Aug 18, 2025
This PR adds the `zones` CLI command, for retrieving zones and their
status.
It also adds AZ information to the `list` and `info` commands.
There is support for all the expected `--format` options.

There is also a change to the base `Command` class, in order to allow it
to receive gRPC callbacks with `const` parameters.

MULTI-1871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants