-
Notifications
You must be signed in to change notification settings - Fork 736
[cli] add retrieval of zones #3925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
014d2c5 to
30bc9c6
Compare
a8dfbc5 to
4f5405a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## availability-zones #3925 +/- ##
======================================================
+ Coverage 89.30% 89.36% +0.05%
======================================================
Files 264 265 +1
Lines 14953 15050 +97
======================================================
+ Hits 13354 13449 +95
- Misses 1599 1601 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
30bc9c6 to
8262d94
Compare
4f5405a to
da81d8c
Compare
8262d94 to
0f21a35
Compare
da81d8c to
252c179
Compare
0f21a35 to
b6d90b8
Compare
b6d90b8 to
eb849f0
Compare
252c179 to
ce22af7
Compare
eb849f0 to
b84318f
Compare
8b07126 to
78e9b91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
78e9b91 to
089be1d
Compare
0f1e320 to
24dac77
Compare
e859b3f to
848b4c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I pushed a change to test_client_cli that adds coverage for zones.cpp
Processing file src/client/cli/cmd/zones.cpp
lines=31 hit=30 functions=8 hit=7
d4e7417 to
989f543
Compare
989f543 to
382dfca
Compare
|
@levkropp this can now be merged, right? |
|
I just got back to #3926, then I noticed this. Do you think in this case we should merge that one into this first? Normally we merge in sequence. |
8709537 to
c5b14fe
Compare
This PR adds the `zones` CLI command, for retrieving zones and their status. It also adds AZ information to the `list` and `info` commands. There is support for all the expected `--format` options. There is also a change to the base `Command` class, in order to allow it to receive gRPC callbacks with `const` parameters. MULTI-1871
This PR adds the
zonesCLI command, for retrieving zones and their status.It also adds AZ information to the
listandinfocommands.There is support for all the expected
--formatoptions.There is also a change to the base
Commandclass, in order to allow it to receive gRPC callbacks withconstparameters.MULTI-1871