Az integration #3924
Merged
Az integration #3924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-toterman
force-pushed
the
az-definitions
branch
from
d5a16ab to
887fb23
Compare
andrei-toterman
force-pushed
the
az-integration
branch
from
014d2c5 to
30bc9c6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## availability-zones #3924 +/- ##
======================================================
+ Coverage 89.21% 89.30% +0.09%
======================================================
Files 260 264 +4
Lines 14762 14953 +191
======================================================
+ Hits 13170 13354 +184
- Misses 1592 1599 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xmkg
requested changes
Feb 10, 2025
src/platform/backends/shared/base_availability_zone_manager.cpp
Outdated
Show resolved
Hide resolved
src/platform/backends/shared/base_availability_zone_manager.cpp
Outdated
Show resolved
Hide resolved
src/platform/backends/shared/base_availability_zone_manager.cpp
Outdated
Show resolved
Hide resolved
src/platform/backends/shared/base_availability_zone_manager.cpp
Outdated
Show resolved
Hide resolved
src/platform/backends/shared/base_availability_zone_manager.cpp
Outdated
Show resolved
Hide resolved
andrei-toterman
force-pushed
the
az-definitions
branch
2 times, most recently
from
710fcac to
dc51fad
Compare
Merged
andrei-toterman
force-pushed
the
az-definitions
branch
from
dc51fad to
03cb3ec
Compare
andrei-toterman
force-pushed
the
az-integration
branch
2 times, most recently
from
8262d94 to
0f21a35
Compare
andrei-toterman
force-pushed
the
az-definitions
branch
from
03cb3ec to
0b7befc
Compare
ricab
reviewed
Mar 1, 2025
There was a problem hiding this comment.
Hey Andrei, I finally managed to give this some well-deserved attention, but I have a lot to go still, so I am submitting what I have for now. So far so good. I reviewed the daemon code and it was comforting to see all the logic being kept from it, for a change 👍
ricab
requested changes
Mar 7, 2025
|
One other thing, is this represented in Jira somehow? |
andrei-toterman
force-pushed
the
az-definitions
branch
2 times, most recently
from
4834aec to
dde7d48
Compare
andrei-toterman
force-pushed
the
az-integration
branch
from
0f21a35 to
b6d90b8
Compare
andrei-toterman
force-pushed
the
az-definitions
branch
2 times, most recently
from
baac8f3 to
f3e0414
Compare
andrei-toterman
force-pushed
the
az-integration
branch
2 times, most recently
from
eb849f0 to
b84318f
Compare
andrei-toterman
force-pushed
the
az-definitions
branch
2 times, most recently
from
55da751 to
0e5434c
Compare
andrei-toterman
force-pushed
the
availability-zones
branch
from
859417f to
269e217
Compare
andrei-toterman
force-pushed
the
az-integration
branch
2 times, most recently
from
0f1e320 to
24dac77
Compare
# Conflicts: # tests/test_blueprint_provider.cpp # tests/test_daemon.cpp # tests/test_delayed_shutdown.cpp # tests/test_sshfs_mount_handler.cpp
|
Hey @Sploder12, is this ready for another look? |
I believe so! |
xmkg
approved these changes
May 28, 2025
ricab
approved these changes
Jul 10, 2025
There was a problem hiding this comment.
Very good, thank you to all the participants!
A special word of appreciation to @Sploder12, who I didn't get a chance to thank properly yet for picking this up doing excellent work 🚀
Sploder12
pushed a commit
that referenced
this pull request
Aug 18, 2025
This PR adds implementations for AZs and for the AZ manager, and integrates them in the daemon and the VMs. There are also many tests file modified, since some APIs changed. The changes in those test files do nothing more than passing in stubs for AZs and the AZ manager where they are required. MULTI-1870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementations for AZs and for the AZ manager, and integrates them in the daemon and the VMs.
There are also many tests file modified, since some APIs changed. The changes in those test files do nothing more than passing in stubs for AZs and the AZ manager where they are required.
MULTI-1870