Skip to content

Az definitions #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Availability Zones
merged 2 commits into from
Apr 7, 2025
Merged

Az definitions #3923

merged 2 commits into from
Apr 7, 2025

Conversation

@andrei-toterman
Copy link
Contributor

@andrei-toterman andrei-toterman commented Feb 7, 2025 •
edited by Sploder12
Loading

This PR adds interfaces for AZs and for an AZ manager, as well as some AZ specific exceptions.

MULTI-1869

@codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (e32b8e6) to head (0e5434c).
Report is 3176 commits behind head on availability-zones.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           availability-zones    #3923   +/-   ##
===================================================
  Coverage               89.20%   89.21%           
===================================================
  Files                     260      260           
  Lines                   14759    14762    +3     
===================================================
+ Hits                    13166    13170    +4     
+ Misses                   1593     1592    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xmkg
xmkg approved these changes Feb 10, 2025
View reviewed changes
@andrei-toterman andrei-toterman force-pushed the az-rpc branch 2 times, most recently from f7d9107 to e7c0a34 Compare February 25, 2025 12:38
levkropp
levkropp approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Good defs and good comments explaining the difference between get_automatic_zone_name and get_default_zone_name 😀

ricab
ricab reviewed Mar 1, 2025
View reviewed changes
ricab
ricab reviewed Mar 7, 2025
View reviewed changes
Base automatically changed from az-rpc to availability-zones April 4, 2025 11:26
@andrei-toterman andrei-toterman merged commit 859417f into availability-zones Apr 7, 2025
24 checks passed
@andrei-toterman andrei-toterman deleted the az-definitions branch April 7, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricab ricab ricab left review comments

@xmkg xmkg xmkg approved these changes

+1 more reviewer

@levkropp levkropp levkropp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrei-toterman @xmkg @ricab @levkropp